All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset
Date: Fri, 09 Mar 2012 15:09:22 +0100	[thread overview]
Message-ID: <4F5A0F12.60904@redhat.com> (raw)
In-Reply-To: <CAJSP0QUg27Q8i_tO88mDLCF9Cx6RbXPXs3NmPX1L0k_uHvKMxA@mail.gmail.com>

Am 09.03.2012 14:20, schrieb Stefan Hajnoczi:
> On Fri, Mar 9, 2012 at 12:46 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> Run the 'quick' group from qemu-iotests during 'make check'.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>  tests/Makefile              |    5 +++++
>>  tests/qemu-iotests-quick.sh |   17 +++++++++++++++++
>>  2 files changed, 22 insertions(+), 0 deletions(-)
>>  create mode 100755 tests/qemu-iotests-quick.sh
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 74b29dc..571ad42 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -1,6 +1,9 @@
>> +export SRC_PATH
> 
> I'm not sure I like this.  Could we avoid this with:
> 
> cd $(dirname "$0")/tests/qemu-iotests
> 
> instead of using SRC_PATH in qemu-iotests-quick.sh?

Do you really like this better? To me it doesn't feel cleaner.

Kevin

  reply	other threads:[~2012-03-09 14:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-09 12:46 [Qemu-devel] [PATCH v2 0/3] make check: Add qemu-iotests subset Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 1/3] qemu-iotests: Mark some tests as quick Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset Kevin Wolf
2012-03-09 13:20   ` Stefan Hajnoczi
2012-03-09 14:09     ` Kevin Wolf [this message]
2012-03-09 15:44       ` Stefan Hajnoczi
2012-03-09 19:31   ` Anthony Liguori
2012-03-12  8:34     ` Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 3/3] Add 'make check-block' Kevin Wolf
2012-03-09 13:26   ` Andreas Färber
2012-03-09 14:05     ` Kevin Wolf
2012-03-09 14:12       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5A0F12.60904@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.