From: "Andreas Färber" <afaerber@suse.de>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'
Date: Fri, 09 Mar 2012 15:12:46 +0100 [thread overview]
Message-ID: <4F5A0FDE.9030503@suse.de> (raw)
In-Reply-To: <4F5A0E3B.1080200@redhat.com>
Am 09.03.2012 15:05, schrieb Kevin Wolf:
> Am 09.03.2012 14:26, schrieb Andreas Färber:
>> Am 09.03.2012 13:46, schrieb Kevin Wolf:
>>> check: $(CHECKS)
>>> $(call quiet-command, gtester $(CHECKS), " CHECK")
>>> +
>>> +check-block:
>>> + $(call quiet-command, $(SRC_PATH)/tests/check-block.sh , " CHECK")
>>
>> Please use $(SHELL) here.
>
> Ok, I can do that. But what's the difference?
The difference is that /bin/sh can be dash or some non-POSIX-compliant
shell. There's an open bug about Solaris 10 needing some oddly named
shell instead of /bin/sh, for instance. By executing ./check-block.sh
via shebang, a shell different from the one the user has explicitly used
for configure gets used. There's an example of $(SHELL) use in ../Makefile.
An alternative would be inlining your script into the Makefile.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-03-09 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 12:46 [Qemu-devel] [PATCH v2 0/3] make check: Add qemu-iotests subset Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 1/3] qemu-iotests: Mark some tests as quick Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 2/3] make check: Add qemu-iotests subset Kevin Wolf
2012-03-09 13:20 ` Stefan Hajnoczi
2012-03-09 14:09 ` Kevin Wolf
2012-03-09 15:44 ` Stefan Hajnoczi
2012-03-09 19:31 ` Anthony Liguori
2012-03-12 8:34 ` Kevin Wolf
2012-03-09 12:46 ` [Qemu-devel] [PATCH v2 3/3] Add 'make check-block' Kevin Wolf
2012-03-09 13:26 ` Andreas Färber
2012-03-09 14:05 ` Kevin Wolf
2012-03-09 14:12 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A0FDE.9030503@suse.de \
--to=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.