From: Kukjin Kim <kgene.kim@samsung.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
linux@arm.linux.org.uk, kgene.kim@samsung.com,
kyungmin.park@samsung.com, patches@linaro.org
Subject: Re: [PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata
Date: Fri, 09 Mar 2012 08:04:04 -0800 [thread overview]
Message-ID: <4F5A29F4.7020308@samsung.com> (raw)
In-Reply-To: <1330593446-663-1-git-send-email-tushar.behera@linaro.org>
On 03/01/12 01:17, Tushar Behera wrote:
> The function s3c_set_platdata is defined with __init attribute, hence the
> functions calling s3c_set_platdata should also be defined with __init
> attribute.
>
> Even though all the modified functions are called from xxx_machine_init()
> functions, it is still better to define each of them with __init attribute.
>
> Tushar Behera (4):
> ARM: EXYNOS: Add __init attribute to nuri_camera_init()
> ARM: EXYNOS: Add __init attribute to universal_camera_init()
> ARM: SAMSUNG: Add __init attribute to samsung_bl_set()
> ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers
>
> arch/arm/mach-exynos/mach-nuri.c | 2 +-
> arch/arm/mach-exynos/mach-universal_c210.c | 2 +-
> arch/arm/plat-samsung/dev-backlight.c | 2 +-
> arch/arm/plat-samsung/devs.c | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
Looks good to me, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata
Date: Fri, 09 Mar 2012 08:04:04 -0800 [thread overview]
Message-ID: <4F5A29F4.7020308@samsung.com> (raw)
In-Reply-To: <1330593446-663-1-git-send-email-tushar.behera@linaro.org>
On 03/01/12 01:17, Tushar Behera wrote:
> The function s3c_set_platdata is defined with __init attribute, hence the
> functions calling s3c_set_platdata should also be defined with __init
> attribute.
>
> Even though all the modified functions are called from xxx_machine_init()
> functions, it is still better to define each of them with __init attribute.
>
> Tushar Behera (4):
> ARM: EXYNOS: Add __init attribute to nuri_camera_init()
> ARM: EXYNOS: Add __init attribute to universal_camera_init()
> ARM: SAMSUNG: Add __init attribute to samsung_bl_set()
> ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers
>
> arch/arm/mach-exynos/mach-nuri.c | 2 +-
> arch/arm/mach-exynos/mach-universal_c210.c | 2 +-
> arch/arm/plat-samsung/dev-backlight.c | 2 +-
> arch/arm/plat-samsung/devs.c | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
Looks good to me, applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-09 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 9:17 [PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata Tushar Behera
2012-03-01 9:17 ` Tushar Behera
2012-03-01 9:17 ` [PATCH 1/4] ARM: EXYNOS: Add __init attribute to nuri_camera_init() Tushar Behera
2012-03-01 9:17 ` Tushar Behera
2012-03-01 9:33 ` Sylwester Nawrocki
2012-03-01 9:33 ` Sylwester Nawrocki
2012-03-01 9:17 ` [PATCH 2/4] ARM: EXYNOS: Add __init attribute to universal_camera_init() Tushar Behera
2012-03-01 9:17 ` Tushar Behera
2012-03-01 9:33 ` Sylwester Nawrocki
2012-03-01 9:33 ` Sylwester Nawrocki
2012-03-01 9:17 ` [PATCH 3/4] ARM: SAMSUNG: Add __init attribute to samsung_bl_set() Tushar Behera
2012-03-01 9:17 ` Tushar Behera
2012-03-01 9:17 ` [PATCH 4/4] ARM: SAMSUNG: Add __init attribute to xxx_set_platdata() wrappers Tushar Behera
2012-03-01 9:17 ` Tushar Behera
2012-03-09 16:04 ` Kukjin Kim [this message]
2012-03-09 16:04 ` [PATCH 0/4] ARM: SAMSUNG: Add __init attribute to functions calling s3c_set_platdata Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A29F4.7020308@samsung.com \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.