[PATCH] ARM: SAMSUNG: Correct MIPI-CSIS io memory resource definition

[PATCH] ARM: SAMSUNG: Correct MIPI-CSIS io memory resource definition

[Sylwester Nawrocki]

The resources size is increased to 16KB to also include the non-image packet
data buffers (CSIS_PKTDATAn). The 4KiB region is only sufficient when the
driver is not using the packet data buffers.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

---
Hi Kgene,

This patch is a fix, but it should be needed starting from v3.4,
when the MIPI-CSIS driver is updated.

Thanks,
Sylwester
---
 arch/arm/plat-samsung/devs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 848b9c6..130fdaa 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -904,7 +904,7 @@ struct platform_device s5p_device_mfc_r = {
 
 #ifdef CONFIG_S5P_DEV_CSIS0
 static struct resource s5p_mipi_csis0_resource[] = {
-	[0] = DEFINE_RES_MEM(S5P_PA_MIPI_CSIS0, SZ_4K),
+	[0] = DEFINE_RES_MEM(S5P_PA_MIPI_CSIS0, SZ_16K),
 	[1] = DEFINE_RES_IRQ(IRQ_MIPI_CSIS0),
 };
 
@@ -918,7 +918,7 @@ struct platform_device s5p_device_mipi_csis0 = {
 
 #ifdef CONFIG_S5P_DEV_CSIS1
 static struct resource s5p_mipi_csis1_resource[] = {
-	[0] = DEFINE_RES_MEM(S5P_PA_MIPI_CSIS1, SZ_4K),
+	[0] = DEFINE_RES_MEM(S5P_PA_MIPI_CSIS1, SZ_16K),
 	[1] = DEFINE_RES_IRQ(IRQ_MIPI_CSIS1),
 };
 
-- 
1.7.9

RE: [PATCH] ARM: SAMSUNG: Correct MIPI-CSIS io memory resource definition

[Kukjin Kim]

Sylwester Nawrocki wrote:
> 
> The resources size is increased to 16KB to also include the non-image
> packet
> data buffers (CSIS_PKTDATAn). The 4KiB region is only sufficient when the
> driver is not using the packet data buffers.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> 
> ---
> Hi Kgene,
> 
Hi
 
> This patch is a fix, but it should be needed starting from v3.4,
> when the MIPI-CSIS driver is updated.
> 
OK, will apply.

But it's time to replace static definition for resource and as a note, I'm
going to prepare it :)

If any updates, let you know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH] ARM: SAMSUNG: Correct MIPI-CSIS io memory resource definition

[Kukjin Kim]

On 02/15/12 22:00, Kukjin Kim wrote:
> Sylwester Nawrocki wrote:
>>
>> The resources size is increased to 16KB to also include the non-image
>> packet
>> data buffers (CSIS_PKTDATAn). The 4KiB region is only sufficient when the
>> driver is not using the packet data buffers.
>>
>> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>>
>> ---
>> Hi Kgene,
>>
> Hi
>
>> This patch is a fix, but it should be needed starting from v3.4,
>> when the MIPI-CSIS driver is updated.
>>
> OK, will apply.
>
> But it's time to replace static definition for resource and as a note, I'm
> going to prepare it :)
>
> If any updates, let you know.
>
Applied, thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.