Re: Remaining ZFS Changes for 2.00 (Was: Re: Freeze on 27 February)

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

On 08.03.2012 23:51, Richard Laager wrote:
> I believe the following change is still needed to support pool names
> with spaces. That said, maybe we shouldn't care about pool names with
> spaces. If a pool name has spaces, then we need some way to escape it
> when building the linux_entry command line. Then the initrd needs to
> unescape it. That seems like a lot of hassle for a configuration that's
> likely to be extremely uncommon even if GRUB does support it.
>
> Index: grub/util/getroot.c
> ===================================================================
> --- grub.orig/util/getroot.c	2012-02-03 05:21:06.838056692 -0600
> +++ grub/util/getroot.c	2012-02-03 05:22:36.227364000 -0600
> @@ -285,8 +285,7 @@
>  	      st++;
>  	    break;
>  	  case 1:
> -	    if (!strcmp (name, poolname))
> -	      st++;
> +	    st++;
>
The root cause of the problem is that sscanf on the top of this loop is
improper way to parse strings with spaces so probably this will create
more problems e.g. if for some reason we have an extra empty line. Also
if a space is present if member devices e're back to the same problem.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]