All of lore.kernel.org
 help / color / mirror / Atom feed
From: stigge@antcom.de (Roland Stigge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/3] USB: ohci-nxp: Support for LPC32xx
Date: Sun, 11 Mar 2012 11:16:43 +0100	[thread overview]
Message-ID: <4F5C7B8B.7050508@antcom.de> (raw)
In-Reply-To: <20120311074323.GA30894@pengutronix.de>

Hi,

On 11/03/12 08:43, Wolfram Sang wrote:
>>> And while we are at it: Could you also try replacing
>>> i2c_write() with i2c_smbus_write_byte_data(isp1301_i2c_client,
>>> reg, val)?
>> 
>> Interestingly now, replacing i2c_write() calls with 
>> i2c_smbus_write_byte_data() did _not_ work (hardware
>> initialization failure). I guess this is due to the differences
>> between i2c and smbus, and the hardware only handles the former
>> correctly?
> 
> Did you take into consideration that the smbus-call has (client,
> reg, val) as arguments while i2c_write has (val, reg), that is you
> have to swap the arguments?

Yes, that's it! :-)

I'll update my patch to not use i2c_write() anymore.

For the remaining i2c_write() in the current kernel driver, I will
include an additional patch to remove it completely in favour of
i2c_smbus_write_byte_data().

Thanks,

Roland

WARNING: multiple messages have this Message-ID (diff)
From: Roland Stigge <stigge@antcom.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	kevin.wells@nxp.com, linux-arm-kernel@lists.infradead.org,
	arnd@arndb.de
Subject: Re: [PATCH v5 3/3] USB: ohci-nxp: Support for LPC32xx
Date: Sun, 11 Mar 2012 11:16:43 +0100	[thread overview]
Message-ID: <4F5C7B8B.7050508@antcom.de> (raw)
In-Reply-To: <20120311074323.GA30894@pengutronix.de>

Hi,

On 11/03/12 08:43, Wolfram Sang wrote:
>>> And while we are at it: Could you also try replacing
>>> i2c_write() with i2c_smbus_write_byte_data(isp1301_i2c_client,
>>> reg, val)?
>> 
>> Interestingly now, replacing i2c_write() calls with 
>> i2c_smbus_write_byte_data() did _not_ work (hardware
>> initialization failure). I guess this is due to the differences
>> between i2c and smbus, and the hardware only handles the former
>> correctly?
> 
> Did you take into consideration that the smbus-call has (client,
> reg, val) as arguments while i2c_write has (val, reg), that is you
> have to swap the arguments?

Yes, that's it! :-)

I'll update my patch to not use i2c_write() anymore.

For the remaining i2c_write() in the current kernel driver, I will
include an additional patch to remove it completely in favour of
i2c_smbus_write_byte_data().

Thanks,

Roland

  reply	other threads:[~2012-03-11 10:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10 19:36 [PATCH v5 0/3] USB: OHCI-HCD: Support for LPC32xx Roland Stigge
2012-03-10 19:36 ` Roland Stigge
2012-03-10 19:36 ` [PATCH v5 1/3] USB: OHCI-HCD: Rename ohci-pnx4008 to ohci-nxp Roland Stigge
2012-03-10 19:36   ` Roland Stigge
2012-03-10 19:36 ` [PATCH v5 2/3] USB: ohci-nxp: Rename symbols from pnx4008 to nxp Roland Stigge
2012-03-10 19:36   ` Roland Stigge
2012-03-10 19:36 ` [PATCH v5 3/3] USB: ohci-nxp: Support for LPC32xx Roland Stigge
2012-03-10 19:36   ` Roland Stigge
2012-03-10 20:49   ` Wolfram Sang
2012-03-10 20:49     ` Wolfram Sang
2012-03-10 20:53     ` Wolfram Sang
2012-03-10 20:53       ` Wolfram Sang
2012-03-10 22:29     ` Roland Stigge
2012-03-10 22:29       ` Roland Stigge
2012-03-11  7:43       ` Wolfram Sang
2012-03-11  7:43         ` Wolfram Sang
2012-03-11 10:16         ` Roland Stigge [this message]
2012-03-11 10:16           ` Roland Stigge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5C7B8B.7050508@antcom.de \
    --to=stigge@antcom.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.