From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: fix error path in pinconf_map_to_setting()
Date: Mon, 12 Mar 2012 15:04:43 -0600 [thread overview]
Message-ID: <4F5E64EB.6050200@wwwdotorg.org> (raw)
In-Reply-To: <1331584870-10077-1-git-send-email-linus.walleij@stericsson.com>
On 03/12/2012 02:41 PM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The code was using the union member
> setting->data.configs.group_or_pin to store a potential
> error code, but since that member is unsigned the
> < 0 comparison was not true, letting errors pass thru,
"thru" is a pet peeve of mine; it'd be great to spell this correctly as
"through".
> ending up as mapped to pin "-22". Fix this up and print
> the error.
Oops. Sorry about that.
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
...
> - setting->data.configs.group_or_pin =
> - pin_get_from_name(pctldev,
> - map->data.configs.group_or_pin);
> - if (setting->data.configs.group_or_pin < 0)
> - return setting->data.configs.group_or_pin;
> + ret = pin_get_from_name(pctldev,
> + map->data.configs.group_or_pin);
> + if (ret < 0) {
"ret" here is named "pin" other places pin_get_from_name() is called,
and that naming seems to make a bit more sense here too.
Otherwise,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shawn Guo <shawn.guo@freescale.com>,
Thomas Abraham <thomas.abraham@linaro.org>,
Dong Aisheng <dong.aisheng@linaro.org>,
Rajendra Nayak <rajendra.nayak@linaro.org>,
Haojian Zhuang <haojian.zhuang@marvell.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pinctrl: fix error path in pinconf_map_to_setting()
Date: Mon, 12 Mar 2012 15:04:43 -0600 [thread overview]
Message-ID: <4F5E64EB.6050200@wwwdotorg.org> (raw)
In-Reply-To: <1331584870-10077-1-git-send-email-linus.walleij@stericsson.com>
On 03/12/2012 02:41 PM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
>
> The code was using the union member
> setting->data.configs.group_or_pin to store a potential
> error code, but since that member is unsigned the
> < 0 comparison was not true, letting errors pass thru,
"thru" is a pet peeve of mine; it'd be great to spell this correctly as
"through".
> ending up as mapped to pin "-22". Fix this up and print
> the error.
Oops. Sorry about that.
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
...
> - setting->data.configs.group_or_pin =
> - pin_get_from_name(pctldev,
> - map->data.configs.group_or_pin);
> - if (setting->data.configs.group_or_pin < 0)
> - return setting->data.configs.group_or_pin;
> + ret = pin_get_from_name(pctldev,
> + map->data.configs.group_or_pin);
> + if (ret < 0) {
"ret" here is named "pin" other places pin_get_from_name() is called,
and that naming seems to make a bit more sense here too.
Otherwise,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
next prev parent reply other threads:[~2012-03-12 21:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 20:41 [PATCH] pinctrl: fix error path in pinconf_map_to_setting() Linus Walleij
2012-03-12 20:41 ` Linus Walleij
2012-03-12 21:04 ` Stephen Warren [this message]
2012-03-12 21:04 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E64EB.6050200@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.