From: Pavel Hofman <pavel.hofman@ivitera.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, Ondrej Zary <linux@rainbow-software.org>
Subject: Re: Triple implementation of WM8766 and quadruple WM8776!
Date: Tue, 13 Mar 2012 10:53:09 +0100 [thread overview]
Message-ID: <4F5F1905.7040609@ivitera.com> (raw)
In-Reply-To: <4F5F1776.4020904@ladisch.de>
Dne 13.3.2012 10:46, Clemens Ladisch napsal(a):
> Ondrej Zary wrote:
>> I'm trying do implement support for Philips PSC724 Ultimate Edge card, which
>> is based on VT1722 + WM8776 + WM8766 chips. Found that the best file to base
>> my work on is sound/pci/ice1712/se.c (as SE-200PCI card contains both WM8776
>> and WM8766 chips).
>>
>> While doing this, found that there are three implementations of WM8766 codec
>> control, two of them in the same driver(!):
>> sound/pci/ice1712/se.c
>> sound/pci/ice1712/prodigy_hifi.c
>> sound/pci/oxygen/xonar_wm87x6.c (+sound/pci/oxygen/wm8766.h)
>>
>> And WM8776 status is even worse, there are four implementations, again two
>> being in the same driver:
>> sound/pci/ice1712/se.c
>> sound/pci/ice1712/maya44.c
>> sound/pci/oxygen/xonar_wm87x6.c (+sound/pci/oxygen/wm8776.h)
>> sound/soc/codecs/wm8776.c (this one being official and stand-alone module but
>> it does not seem to be usable as a part of sound card driver)
>
.....
>
> I'd suggest to move the common parts of the three ice1712 drivers into
> separate files. You could make the interface of those files similar to
> ASoC codec drivers to make later porting easier.
How about a solution similar to AKM codecs in i2c/other? Several ice1724
cards make use of those modules, easy to support and re-use. IMO cleaner
approach than duplicating ICE1724 to the ASoC framework.
Pavel.
next prev parent reply other threads:[~2012-03-13 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 21:40 Triple implementation of WM8766 and quadruple WM8776! Ondrej Zary
2012-03-13 9:46 ` Clemens Ladisch
2012-03-13 9:46 ` [alsa-devel] " Clemens Ladisch
2012-03-13 9:53 ` Pavel Hofman [this message]
2012-03-13 9:58 ` Takashi Iwai
2012-03-13 10:05 ` Pavel Hofman
2012-03-13 21:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F1905.7040609@ivitera.com \
--to=pavel.hofman@ivitera.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.