Re: [Qemu-devel] We need more reviewers/maintainers!!

[Avi Kivity <avi@redhat.com>]

On 03/12/2012 10:27 PM, Anthony Liguori wrote:
>> I agree that more maintainers would be good, but we also need
>> more people with commit rights.
>
> I disagree strongly.  Having multiple pushers makes things difficult
> and encourages people to push without testing.  Part of what makes
> pushing take longer than it should today is that my test cycle takes
> at least 1-2 hours and it's not uncommon to have to go through 3-4
> cycles of rebasing before being able to push.

This really sucks.

If testing was automated, we could have a staging branch where
maintainers would push patches, they'd get tested automatically and then
graduate to master.  The workflow would look something like

  git fetch
  git checkout staging
  git rebase origin/staging
  <apply patches, pull trees>
  git push staging
  <wait>
  <staging gets merged into master autoamatically, or you get an email
from the test system>

If testing cannot be automated, perhaps a lock around the tree would help.

-- 
error compiling committee.c: too many arguments to function