From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Lluís Vilanova" <vilanova@ac.upc.edu>,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>,
"Avi Kivity" <avi@redhat.com>
Subject: Re: [Qemu-devel] We need more reviewers/maintainers!!
Date: Wed, 14 Mar 2012 09:17:10 -0500 [thread overview]
Message-ID: <4F60A866.2050304@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA-w3vD-zqM3r4nuV5JRV3srAcEa7Usp64B3MReHfmX=gQ@mail.gmail.com>
On 03/14/2012 08:58 AM, Peter Maydell wrote:
> On 14 March 2012 13:52, Anthony Liguori<anthony@codemonkey.ws> wrote:
>> On 03/14/2012 08:50 AM, Andreas Färber wrote:
>>> What I have wondered is, is there any semantic difference between "Ack",
>>> "Acked", "ACK" and "Acked-by: name<email>"? I.e., when someone replies
>>> with "Ack", should one document that as an Acked-by for a PULL?
>>
>>
>> No, Acked-by: name<email> is a formal statement. You shouldn't infer an
>> Acked-by IMHO.
>
> This is in contradiction to the kernel docs we reference, which say:
> # Acked-by: is not as formal as Signed-off-by:. It is a record that the acker
> # has at least reviewed the patch and has indicated acceptance. Hence patch
> # mergers will sometimes manually convert an acker's "yep, looks good to me"
> # into an Acked-by:.
Oh, I guess I stand corrected. It would certainly surprise me if someone added
my Acked-by without asking me but maybe this is just American politeness...
Regards,
Anthony Liguori
>
> -- PMM
>
next prev parent reply other threads:[~2012-03-14 14:17 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 17:06 [Qemu-devel] We need more reviewers/maintainers!! Stefano Stabellini
2012-03-12 17:16 ` Anthony Liguori
2012-03-12 17:34 ` Stefano Stabellini
2012-03-12 18:48 ` Anthony Liguori
2012-03-12 19:10 ` Stefano Stabellini
2012-03-12 19:04 ` Anthony Liguori
2012-03-12 19:21 ` Stefano Stabellini
2012-03-12 19:38 ` Anthony Liguori
2012-03-13 11:34 ` Stefano Stabellini
2012-03-13 11:27 ` Kevin Wolf
2012-03-13 11:41 ` Stefano Stabellini
2012-03-13 12:12 ` Paolo Bonzini
2012-03-12 18:03 ` Lluís Vilanova
2012-03-12 18:10 ` Anthony Liguori
2012-03-12 19:39 ` Lluís Vilanova
2012-03-12 19:43 ` Anthony Liguori
2012-03-12 18:18 ` Stefano Stabellini
2012-03-13 13:27 ` Avi Kivity
2012-03-14 13:50 ` Andreas Färber
2012-03-14 13:52 ` Anthony Liguori
2012-03-14 13:58 ` Peter Maydell
2012-03-14 14:17 ` Anthony Liguori [this message]
2012-03-14 14:25 ` Andreas Färber
2012-03-13 10:38 ` Andreas Färber
2012-03-12 19:18 ` Michael Roth
2012-03-13 11:11 ` Stefano Stabellini
2012-03-12 20:12 ` Stefan Weil
2012-03-12 20:24 ` Peter Maydell
2012-03-12 20:29 ` Anthony Liguori
2012-03-12 20:43 ` Peter Maydell
2012-03-12 21:06 ` Anthony Liguori
2012-03-12 21:09 ` malc
2012-03-12 21:13 ` Anthony Liguori
2012-03-12 21:41 ` Stefan Weil
2012-03-12 21:52 ` Anthony Liguori
2012-03-12 21:43 ` malc
2012-03-12 21:49 ` Anthony Liguori
2012-03-12 22:53 ` malc
2012-03-12 21:16 ` Peter Maydell
2012-03-12 21:19 ` Anthony Liguori
2012-03-13 10:39 ` Stefan Hajnoczi
2012-03-12 20:40 ` Michael S. Tsirkin
2012-03-12 20:27 ` Anthony Liguori
2012-03-12 21:12 ` Stefan Weil
2012-03-12 21:18 ` Anthony Liguori
2012-03-12 23:32 ` Andreas Färber
2012-03-13 0:16 ` Anthony Liguori
2012-03-13 0:54 ` Alexander Graf
2012-03-13 1:01 ` Andreas Färber
2012-03-13 1:23 ` Alexander Graf
2012-03-13 1:31 ` Super Bisquit
2012-03-13 1:39 ` Anthony Liguori
2012-03-13 2:04 ` Alexander Graf
2012-03-13 2:05 ` Anthony Liguori
2012-03-14 19:47 ` Blue Swirl
2012-03-13 9:09 ` Peter Maydell
2012-03-13 13:50 ` Avi Kivity
2012-03-13 14:12 ` Peter Maydell
2012-03-13 14:39 ` Avi Kivity
2012-03-13 14:43 ` Anthony Liguori
2012-03-13 14:46 ` Alexander Graf
2012-03-13 14:54 ` Peter Maydell
2012-03-13 14:49 ` Andreas Färber
2012-03-13 14:57 ` Avi Kivity
2012-03-13 15:13 ` Eric Blake
2012-03-12 21:24 ` Stefan Weil
2012-03-13 13:40 ` Avi Kivity
2012-03-13 14:00 ` Anthony Liguori
2012-03-13 14:38 ` Avi Kivity
2012-03-13 14:41 ` Anthony Liguori
2012-03-14 20:00 ` Blue Swirl
2012-03-14 19:55 ` Blue Swirl
2012-03-13 10:41 ` Stefan Hajnoczi
2012-03-13 16:31 ` Andreas Färber
2012-03-13 18:14 ` Stefan Weil
2012-03-14 9:17 ` Stefan Hajnoczi
2012-07-18 9:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60A866.2050304@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=avi@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.