All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/3] clk: introduce the common clock framework
Date: Tue, 13 Mar 2012 16:48:00 -0500	[thread overview]
Message-ID: <4F5FC090.90005@gmail.com> (raw)
In-Reply-To: <1331366064-1273-3-git-send-email-mturquette@linaro.org>

Mike,

On 03/10/2012 01:54 AM, Mike Turquette wrote:
> The common clock framework defines a common struct clk useful across
> most platforms as well as an implementation of the clk api that drivers
> can use safely for managing clocks.
> 
> The net result is consolidation of many different struct clk definitions
> and platform-specific clock framework implementations.
> 
> This patch introduces the common struct clk, struct clk_ops and an
> implementation of the well-known clock api in include/clk/clk.h.
> Platforms may define their own hardware-specific clock structure and
> their own clock operation callbacks, so long as it wraps an instance of
> struct clk_hw.
> 
> See Documentation/clk.txt for more details.
> 
> This patch is based on the work of Jeremy Kerr, which in turn was based
> on the work of Ben Herrenschmidt.
> 
> Signed-off-by: Mike Turquette <mturquette@linaro.org>
> Signed-off-by: Mike Turquette <mturquette@ti.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jeremy Kerr <jeremy.kerr@canonical.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Arnd Bergman <arnd.bergmann@linaro.org>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Richard Zhao <richard.zhao@linaro.org>
> Cc: Saravana Kannan <skannan@codeaurora.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Deepak Saxena <dsaxena@linaro.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Andrew Lunn <andrew@lunn.ch>

snip

> +
> +	/*
> +	 * walk the list of orphan clocks and reparent any that are children of
> +	 * this clock
> +	 */
> +	hlist_for_each_entry(orphan, tmp, &clk_orphan_list, child_node)

In __clk_init, this needs to be hlist_for_each_entry_safe as entries can
be removed.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Russell King <linux@arm.linux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>,
	linaro-dev@lists.linaro.org,
	Saravana Kannan <skannan@codeaurora.org>,
	Jeremy Kerr <jeremy.kerr@canonical.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergman <arnd.bergmann@linaro.org>,
	patches@linaro.org, Sascha Hauer <s.hauer@pengutronix.de>,
	Rob Herring <rob.herring@calxeda.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Paul Walmsley <paul@pwsan.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] clk: introduce the common clock framework
Date: Tue, 13 Mar 2012 16:48:00 -0500	[thread overview]
Message-ID: <4F5FC090.90005@gmail.com> (raw)
In-Reply-To: <1331366064-1273-3-git-send-email-mturquette@linaro.org>

Mike,

On 03/10/2012 01:54 AM, Mike Turquette wrote:
> The common clock framework defines a common struct clk useful across
> most platforms as well as an implementation of the clk api that drivers
> can use safely for managing clocks.
> 
> The net result is consolidation of many different struct clk definitions
> and platform-specific clock framework implementations.
> 
> This patch introduces the common struct clk, struct clk_ops and an
> implementation of the well-known clock api in include/clk/clk.h.
> Platforms may define their own hardware-specific clock structure and
> their own clock operation callbacks, so long as it wraps an instance of
> struct clk_hw.
> 
> See Documentation/clk.txt for more details.
> 
> This patch is based on the work of Jeremy Kerr, which in turn was based
> on the work of Ben Herrenschmidt.
> 
> Signed-off-by: Mike Turquette <mturquette@linaro.org>
> Signed-off-by: Mike Turquette <mturquette@ti.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Jeremy Kerr <jeremy.kerr@canonical.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Arnd Bergman <arnd.bergmann@linaro.org>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Richard Zhao <richard.zhao@linaro.org>
> Cc: Saravana Kannan <skannan@codeaurora.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Linus Walleij <linus.walleij@stericsson.com>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Deepak Saxena <dsaxena@linaro.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Andrew Lunn <andrew@lunn.ch>

snip

> +
> +	/*
> +	 * walk the list of orphan clocks and reparent any that are children of
> +	 * this clock
> +	 */
> +	hlist_for_each_entry(orphan, tmp, &clk_orphan_list, child_node)

In __clk_init, this needs to be hlist_for_each_entry_safe as entries can
be removed.

Rob

  parent reply	other threads:[~2012-03-13 21:48 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10  7:54 [PATCH v6 0/3] common clk framework Mike Turquette
2012-03-10  7:54 ` Mike Turquette
2012-03-10  7:54 ` [PATCH v6 1/3] Documentation: common clk API Mike Turquette
2012-03-10  7:54   ` Mike Turquette
2012-03-10 17:50   ` Andrew Lunn
2012-03-10 17:50     ` Andrew Lunn
2012-03-10  7:54 ` [PATCH v6 2/3] clk: introduce the common clock framework Mike Turquette
2012-03-10  7:54   ` Mike Turquette
2012-03-10 10:51   ` Thomas Gleixner
2012-03-10 10:51     ` Thomas Gleixner
2012-03-10 17:51   ` Andrew Lunn
2012-03-10 17:51     ` Andrew Lunn
2012-03-11  7:52   ` Richard Zhao
2012-03-11  7:52     ` Richard Zhao
2012-03-11 21:02     ` Turquette, Mike
2012-03-11 21:02       ` Turquette, Mike
2012-03-11 11:34   ` Sascha Hauer
2012-03-11 11:34     ` Sascha Hauer
2012-03-11 21:24     ` Turquette, Mike
2012-03-11 21:24       ` Turquette, Mike
2012-03-12 11:51       ` Sascha Hauer
2012-03-12 11:51         ` Sascha Hauer
2012-03-13  3:16         ` Turquette, Mike
2012-03-13  3:16           ` Turquette, Mike
2012-03-13 12:05           ` Sascha Hauer
2012-03-13 12:05             ` Sascha Hauer
2012-03-15  0:51             ` Turquette, Mike
2012-03-15  0:51               ` Turquette, Mike
2012-03-15  9:43               ` Sascha Hauer
2012-03-15  9:43                 ` Sascha Hauer
2012-03-16  6:22                 ` Turquette, Mike
2012-03-16  6:22                   ` Turquette, Mike
2012-03-12 20:14   ` Rob Herring
2012-03-12 20:14     ` Rob Herring
2012-03-13 21:48   ` Rob Herring [this message]
2012-03-13 21:48     ` Rob Herring
2012-03-13 22:41     ` Turquette, Mike
2012-03-13 22:41       ` Turquette, Mike
2012-03-10  7:54 ` [PATCH v6 3/3] clk: basic clock hardware types Mike Turquette
2012-03-10  7:54   ` Mike Turquette
2012-03-10 18:01   ` Andrew Lunn
2012-03-10 18:01     ` Andrew Lunn
2012-03-12 20:18   ` Rob Herring
2012-03-12 20:18     ` Rob Herring
2012-03-12 20:58     ` Turquette, Mike
2012-03-12 20:58       ` Turquette, Mike
2012-03-12 22:00       ` Rob Herring
2012-03-12 22:00         ` Rob Herring
2012-03-13  3:50   ` Matt Sealey
2012-03-13  3:50     ` Matt Sealey
2012-03-13 10:38     ` Sascha Hauer
2012-03-13 10:38       ` Sascha Hauer
2012-03-14  8:54   ` Richard Zhao
2012-03-14  8:54     ` Richard Zhao
2012-03-14 18:23   ` Sascha Hauer
2012-03-14 18:23     ` Sascha Hauer
2012-03-14 18:38     ` Rob Herring
2012-03-14 18:38       ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5FC090.90005@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.