From: Lars-Peter Clausen <lars@metafoo.de>
To: Ravi Kumar V <kumarrav@codeaurora.org>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSM DMA APIs
Date: Wed, 14 Mar 2012 17:26:55 +0100 [thread overview]
Message-ID: <4F60C6CF.4090608@metafoo.de> (raw)
In-Reply-To: <1331548364-27845-1-git-send-email-kumarrav@codeaurora.org>
> [...]
> +
> +struct dma_async_tx_descriptor *msm_dma_prep_interleaved(struct dma_chan *dchan,
> + struct dma_interleaved_template *xt,
> + unsigned long flags, void *context)
> +{
> +
> + struct msm_dma_chan *chan;
> + struct msm_dma_desc_sw *new;
> + struct adm_box_cmd_t *box_cmd_vaddr;
> + u32 *cmd_cntrl = context;
> +
> + if (!dchan)
> + return ERR_PTR(-EINVAL);
This is supposed to return either NULL or a valid descriptor.
> +
> + if (!xt)
> + return ERR_PTR(-EINVAL);
> [...
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSM DMA APIs
Date: Wed, 14 Mar 2012 17:26:55 +0100 [thread overview]
Message-ID: <4F60C6CF.4090608@metafoo.de> (raw)
In-Reply-To: <1331548364-27845-1-git-send-email-kumarrav@codeaurora.org>
> [...]
> +
> +struct dma_async_tx_descriptor *msm_dma_prep_interleaved(struct dma_chan *dchan,
> + struct dma_interleaved_template *xt,
> + unsigned long flags, void *context)
> +{
> +
> + struct msm_dma_chan *chan;
> + struct msm_dma_desc_sw *new;
> + struct adm_box_cmd_t *box_cmd_vaddr;
> + u32 *cmd_cntrl = context;
> +
> + if (!dchan)
> + return ERR_PTR(-EINVAL);
This is supposed to return either NULL or a valid descriptor.
> +
> + if (!xt)
> + return ERR_PTR(-EINVAL);
> [...
next prev parent reply other threads:[~2012-03-14 16:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 10:32 [PATCH v3 2/2] DMAEngine: Add DMAEngine driver based on old MSM DMA APIs Ravi Kumar V
2012-03-12 10:32 ` Ravi Kumar V
2012-03-12 20:14 ` Daniel Walker
2012-03-12 20:14 ` Daniel Walker
2012-03-13 12:46 ` Ravi Kumar V
2012-03-13 12:46 ` Ravi Kumar V
2012-03-14 15:05 ` Daniel Walker
2012-03-14 15:05 ` Daniel Walker
2012-03-14 20:19 ` David Brown
2012-03-14 20:19 ` David Brown
2012-03-15 18:12 ` Ravi Kumar V
2012-03-15 18:12 ` Ravi Kumar V
2012-08-14 11:00 ` Linus Walleij
2012-08-14 11:00 ` Linus Walleij
[not found] ` <CAPDArRLs23VDJSWpX8xJsXfn+_SV2FcyzLYBF9UAxf=Rv9svGQ@mail.gmail.com>
2012-03-13 19:34 ` David Brown
2012-03-13 19:34 ` David Brown
2012-03-15 17:57 ` Ravi Kumar V
2012-03-15 17:57 ` Ravi Kumar V
2012-03-14 16:26 ` Lars-Peter Clausen [this message]
2012-03-14 16:26 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60C6CF.4090608@metafoo.de \
--to=lars@metafoo.de \
--cc=bryanh@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumarrav@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.