From: walter harms <wharms@bfs.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/unicore32/kernel/dma.c: eliminated unneeded free_irq
Date: Thu, 15 Mar 2012 08:09:42 +0000 [thread overview]
Message-ID: <4F61A3C6.8000607@bfs.de> (raw)
In-Reply-To: <1331798498-13606-1-git-send-email-Julia.Lawall@lip6.fr>
Am 15.03.2012 09:01, schrieb Julia Lawall:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The device remains functional if the second request_irq fails, so the first
> one should not be freed.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> diff --git a/arch/unicore32/kernel/dma.c b/arch/unicore32/kernel/dma.c
> index ae441bc..6184ff2 100644
> --- a/arch/unicore32/kernel/dma.c
> +++ b/arch/unicore32/kernel/dma.c
> @@ -172,8 +172,9 @@ int __init puv3_init_dma(void)
>
> ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL);
> if (ret) {
> + /* the device remains function if this fails, so don't free
> + the previously allocated irq */
> printk(KERN_CRIT "Can't register IRQ for DMAERR\n");
> - free_irq(IRQ_DMA, "DMA");
> return ret;
> }
>
obviously we had the same idea ... i did not see that her it came in the moment i send my reply
sorry for the noise,
re,
wh
WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/unicore32/kernel/dma.c: eliminated unneeded free_irq
Date: Thu, 15 Mar 2012 09:09:42 +0100 [thread overview]
Message-ID: <4F61A3C6.8000607@bfs.de> (raw)
In-Reply-To: <1331798498-13606-1-git-send-email-Julia.Lawall@lip6.fr>
Am 15.03.2012 09:01, schrieb Julia Lawall:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The device remains functional if the second request_irq fails, so the first
> one should not be freed.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> diff --git a/arch/unicore32/kernel/dma.c b/arch/unicore32/kernel/dma.c
> index ae441bc..6184ff2 100644
> --- a/arch/unicore32/kernel/dma.c
> +++ b/arch/unicore32/kernel/dma.c
> @@ -172,8 +172,9 @@ int __init puv3_init_dma(void)
>
> ret = request_irq(IRQ_DMAERR, dma_err_handler, 0, "DMAERR", NULL);
> if (ret) {
> + /* the device remains function if this fails, so don't free
> + the previously allocated irq */
> printk(KERN_CRIT "Can't register IRQ for DMAERR\n");
> - free_irq(IRQ_DMA, "DMA");
> return ret;
> }
>
obviously we had the same idea ... i did not see that her it came in the moment i send my reply
sorry for the noise,
re,
wh
next prev parent reply other threads:[~2012-03-15 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 8:01 [PATCH] arch/unicore32/kernel/dma.c: eliminated unneeded free_irq Julia Lawall
2012-03-15 8:01 ` Julia Lawall
2012-03-15 8:09 ` walter harms [this message]
2012-03-15 8:09 ` walter harms
2012-03-15 8:38 ` Guan Xuetao
2012-03-15 8:38 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61A3C6.8000607@bfs.de \
--to=wharms@bfs.de \
--cc=Julia.Lawall@lip6.fr \
--cc=gxt@mprc.pku.edu.cn \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.