All of lore.kernel.org
 help / color / mirror / Atom feed
From: peppe.cavallaro@st.com (Giuseppe CAVALLARO)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] stmmac: Add device-tree support
Date: Thu, 15 Mar 2012 09:45:31 +0100	[thread overview]
Message-ID: <4F61AC2B.30609@st.com> (raw)
In-Reply-To: <20120314162628.GO18320@game.jcrosoft.org>

On 3/14/2012 5:26 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:38 Wed 14 Mar     , Giuseppe CAVALLARO wrote:
>> On 3/12/2012 3:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 15:05 Mon 12 Mar     , Stefan Roese wrote:
>>>> This patch adds support to configure the STMMAC ethernet driver via
>>>> device-tree instead of platform_data.
>>>>
>>>> Currently, only the properties needed on SPEAr600 are provided. All
>>>> other properties should be added once needed on other platforms.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>>>> Cc: Viresh Kumar <viresh.kumar@st.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/net/stmmac.txt   |   38 +++++++++++
>>>>  .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   66 +++++++++++++++++++-
>>>>  2 files changed, 103 insertions(+), 1 deletion(-)
>>>>  create mode 100644 Documentation/devicetree/bindings/net/stmmac.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
>>>> new file mode 100644
>>>> index 0000000..386a47f
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
>>>> @@ -0,0 +1,38 @@
>>>> +* STMicroelectronics 10/100/1000 Ethernet driver (GMAC)
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be "stm,gmac"
>>
>>> this IP have 2 version at least the GMAC for the second generation and mac for
>>> the first generation
>>
>> yes you are right. STMMAC supports two device generations I named:
>> dwma10/100 and dwmac1000 (gmac).
>>
>> Concerning the latter, we support several different versions of the
>> synopsys GMAC cores ... from 3.30 to 3.61a.
>>
>> For example, stx7108 and Stx7109 have the same GMAC core (also SPEAr600
>> IIRC).
> no PM the PM was only since 7108 IIRC

Sorry! you are right :-)

7109 has the mac10/100 (databook 1.91) and 7105/8 have the gmac databook
3.30.

peppe

> 
> 7109 use mac not gmac IIRC it's 7105 that start to use the GMAC with 300Mbps
> max
>> SPEAr13xx has 3.50a
>> New ST SoC Stxh415 has the 3.60a. etc.
>>
>>>> +- reg: Address and length of the register set for the device
>>>> +- interrupt-parent: Should be the phandle for the interrupt controller
>>>> +  that services interrupts for this device
>>>> +- interrupts: Should contain the STMMAC interrupts
>>>> +- interrupt-names: Should contain the interrupt names "macirq"
>>>> +  "eth_wake_irq" if this interrupt is supported in the "interrupts"
>>>> +  property
>>> optionnal
>>
>> yes
>>
>> note that there will be a new field for lpi IRQ as well
>>
>>>> +- phy-mode: String, operation mode of the PHY interface.
>>>> +  Supported values are: "mii", "rmii", "gmii", "rgmii".
>>>> +- phy-addr: MDIO address of the PHY
>>>> +
>>>> +Optional properties:
>>>> +- stm,prog-burst-len: Specify the burst length
>>>> +- stm,has-gmac: Indicates that the controller supports 1000Mbps
>>> this IP support more mode 10/100/300/1000
>>
>> has_gmac was used to understand on devices w/o the HW cap registers if
>> the core is a gmac... another useful parameter could be : enh_desc
> this need to manage via compatible
> 
> Best Regards,
> J.
> 

WARNING: multiple messages have this Message-ID (diff)
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: Stefan Roese <sr@denx.de>,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@ozlabs.org, Viresh Kumar <viresh.kumar@st.com>
Subject: Re: [PATCH] stmmac: Add device-tree support
Date: Thu, 15 Mar 2012 09:45:31 +0100	[thread overview]
Message-ID: <4F61AC2B.30609@st.com> (raw)
In-Reply-To: <20120314162628.GO18320@game.jcrosoft.org>

On 3/14/2012 5:26 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 12:38 Wed 14 Mar     , Giuseppe CAVALLARO wrote:
>> On 3/12/2012 3:38 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
>>> On 15:05 Mon 12 Mar     , Stefan Roese wrote:
>>>> This patch adds support to configure the STMMAC ethernet driver via
>>>> device-tree instead of platform_data.
>>>>
>>>> Currently, only the properties needed on SPEAr600 are provided. All
>>>> other properties should be added once needed on other platforms.
>>>>
>>>> Signed-off-by: Stefan Roese <sr@denx.de>
>>>> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>>>> Cc: Viresh Kumar <viresh.kumar@st.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/net/stmmac.txt   |   38 +++++++++++
>>>>  .../net/ethernet/stmicro/stmmac/stmmac_platform.c  |   66 +++++++++++++++++++-
>>>>  2 files changed, 103 insertions(+), 1 deletion(-)
>>>>  create mode 100644 Documentation/devicetree/bindings/net/stmmac.txt
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt
>>>> new file mode 100644
>>>> index 0000000..386a47f
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/stmmac.txt
>>>> @@ -0,0 +1,38 @@
>>>> +* STMicroelectronics 10/100/1000 Ethernet driver (GMAC)
>>>> +
>>>> +Required properties:
>>>> +- compatible: Should be "stm,gmac"
>>
>>> this IP have 2 version at least the GMAC for the second generation and mac for
>>> the first generation
>>
>> yes you are right. STMMAC supports two device generations I named:
>> dwma10/100 and dwmac1000 (gmac).
>>
>> Concerning the latter, we support several different versions of the
>> synopsys GMAC cores ... from 3.30 to 3.61a.
>>
>> For example, stx7108 and Stx7109 have the same GMAC core (also SPEAr600
>> IIRC).
> no PM the PM was only since 7108 IIRC

Sorry! you are right :-)

7109 has the mac10/100 (databook 1.91) and 7105/8 have the gmac databook
3.30.

peppe

> 
> 7109 use mac not gmac IIRC it's 7105 that start to use the GMAC with 300Mbps
> max
>> SPEAr13xx has 3.50a
>> New ST SoC Stxh415 has the 3.60a. etc.
>>
>>>> +- reg: Address and length of the register set for the device
>>>> +- interrupt-parent: Should be the phandle for the interrupt controller
>>>> +  that services interrupts for this device
>>>> +- interrupts: Should contain the STMMAC interrupts
>>>> +- interrupt-names: Should contain the interrupt names "macirq"
>>>> +  "eth_wake_irq" if this interrupt is supported in the "interrupts"
>>>> +  property
>>> optionnal
>>
>> yes
>>
>> note that there will be a new field for lpi IRQ as well
>>
>>>> +- phy-mode: String, operation mode of the PHY interface.
>>>> +  Supported values are: "mii", "rmii", "gmii", "rgmii".
>>>> +- phy-addr: MDIO address of the PHY
>>>> +
>>>> +Optional properties:
>>>> +- stm,prog-burst-len: Specify the burst length
>>>> +- stm,has-gmac: Indicates that the controller supports 1000Mbps
>>> this IP support more mode 10/100/300/1000
>>
>> has_gmac was used to understand on devices w/o the HW cap registers if
>> the core is a gmac... another useful parameter could be : enh_desc
> this need to manage via compatible
> 
> Best Regards,
> J.
> 

  reply	other threads:[~2012-03-15  8:45 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12 14:05 [PATCH] stmmac: Add device-tree support Stefan Roese
2012-03-12 14:05 ` Stefan Roese
2012-03-12 14:34 ` Rob Herring
2012-03-12 14:34   ` Rob Herring
2012-03-12 15:06   ` Stefan Roese
2012-03-12 15:06     ` Stefan Roese
2012-03-12 15:14     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 15:14       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 15:30     ` Giuseppe CAVALLARO
2012-03-12 15:30       ` Giuseppe CAVALLARO
2012-03-12 16:23       ` Stefan Roese
2012-03-12 16:23         ` Stefan Roese
2012-03-12 16:46         ` Giuseppe CAVALLARO
2012-03-12 16:46           ` Giuseppe CAVALLARO
2012-03-12 20:07           ` Rob Herring
2012-03-12 20:07             ` Rob Herring
2012-03-12 17:02       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 17:02         ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 14:38 ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 14:38   ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 15:25   ` Stefan Roese
2012-03-12 15:25     ` Stefan Roese
2012-03-12 15:17     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-12 15:17       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 11:38   ` Giuseppe CAVALLARO
2012-03-14 11:38     ` Giuseppe CAVALLARO
2012-03-14 13:07     ` Arnd Bergmann
2012-03-14 13:07       ` Arnd Bergmann
2012-03-14 13:16       ` Giuseppe CAVALLARO
2012-03-14 13:16         ` Giuseppe CAVALLARO
2012-03-14 13:37         ` Stefan Roese
2012-03-14 13:37           ` Stefan Roese
2012-03-14 16:26     ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-14 16:26       ` Jean-Christophe PLAGNIOL-VILLARD
2012-03-15  8:45       ` Giuseppe CAVALLARO [this message]
2012-03-15  8:45         ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F61AC2B.30609@st.com \
    --to=peppe.cavallaro@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.