From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, e.voevodin@samsung.com,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, m.kozlov@samsung.com
Subject: Re: [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implementation
Date: Thu, 15 Mar 2012 11:35:32 +0100 [thread overview]
Message-ID: <4F61C5F4.7000206@suse.de> (raw)
In-Reply-To: <1331796924-30669-2-git-send-email-i.mitsyanko@samsung.com>
Am 15.03.2012 08:35, schrieb Igor Mitsyanko:
> Create 9 exynos4210 i2c interfaces.
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
for the non-technical aspects. One remark below.
> diff --git a/hw/exynos4210_i2c.c b/hw/exynos4210_i2c.c
> new file mode 100644
> index 0000000..42f770d
> --- /dev/null
> +++ b/hw/exynos4210_i2c.c
> +enum {
> + idle,
> + start_bit_received,
> + sending_data,
> + receiving_data
> +};
Usually our enum values are uppercase, not sure if that's a rule.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-15 10:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 7:35 [Qemu-devel] [PATCH V2 0/3] Exynos: i2c, gpio and touchscreen support for NURI board Igor Mitsyanko
2012-03-15 7:35 ` [Qemu-devel] [PATCH V2 1/3] exynos4210: add Exynos4210 i2c implementation Igor Mitsyanko
2012-03-15 10:35 ` Andreas Färber [this message]
2012-03-21 11:55 ` Peter Maydell
2012-03-21 13:07 ` Igor Mitsyanko
2012-03-21 13:09 ` Peter Maydell
2012-03-21 14:18 ` Igor Mitsyanko
2012-03-21 14:24 ` Peter Maydell
2012-04-03 13:54 ` Dmitry Zhurikhin
2012-04-03 14:54 ` Igor Mitsyanko
2012-03-15 7:35 ` [Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO implementation Igor Mitsyanko
2012-03-15 11:06 ` Andreas Färber
2012-03-20 13:27 ` Peter Maydell
2012-03-21 13:01 ` Igor Mitsyanko
2012-03-15 7:35 ` [Qemu-devel] [PATCH V2 3/3] hw: add Atmel maxtouch touchscreen implementation Igor Mitsyanko
2012-03-15 9:48 ` Andreas Färber
2012-03-15 10:25 ` Dmitry Solodkiy
2012-03-15 10:41 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61C5F4.7000206@suse.de \
--to=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.