From: viresh.kumar@st.com (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: SPEAr600: Add device-tree support to SPEAr600 boards
Date: Thu, 15 Mar 2012 16:33:29 +0530 [thread overview]
Message-ID: <4F61CC81.1020902@st.com> (raw)
In-Reply-To: <1331808632-22585-1-git-send-email-sr@denx.de>
On 3/15/2012 4:20 PM, Stefan Roese wrote:
> diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
> +/ {
> + compatible = "st,spear600";
> +
> + cpus {
> + cpu at 0 {
> + compatible = "arm,arm926ejs";
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0x40000000>; /* Real value updated by U-Boot */
> + };
> +
> + ahb {
What is the significance of this name? As i see gpio/spi etc in this list,
which are on apb bus.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + ranges;
> +
> + /* local/cpu GPIO */
> + gpio0: gpio at f0100000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xf0100000 0x1000>;
> + interrupt-parent = <&vic0>;
> + interrupts = <18>;
> + };
> +
> + /* basic GPIO */
> + gpio1: gpio at fc980000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xfc980000 0x1000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <19>;
> + };
> +
> + /* appl GPIO */
> + gpio2: gpio at d8100000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xd8100000 0x1000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <4>;
> + };
> +
> +};
> diff --git a/arch/arm/mach-spear6xx/clock.c b/arch/arm/mach-spear6xx/clock.c
> index ac70e0d..358f280 100644
> --- a/arch/arm/mach-spear6xx/clock.c
> +++ b/arch/arm/mach-spear6xx/clock.c
> @@ -641,8 +641,8 @@ static struct clk_lookup spear_clk_lookups[] = {
> { .con_id = "gpt0_synth_clk", .clk = &gpt0_synth_clk},
> { .con_id = "gpt2_synth_clk", .clk = &gpt2_synth_clk},
> { .con_id = "gpt3_synth_clk", .clk = &gpt3_synth_clk},
> - { .dev_id = "uart0", .clk = &uart0_clk},
> - { .dev_id = "uart1", .clk = &uart1_clk},
> + { .dev_id = "d0000000.serial", .clk = &uart0_clk},
> + { .dev_id = "d0080000.serial", .clk = &uart1_clk},
I didn't got Jean's comment at that time, but now it is ultra clear.
Acked-by: Viresh Kumar <viresh.kumar@st.com>
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
To: Stefan Roese <sr-ynQEQJNshbs@public.gmane.org>
Cc: "devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org"
<devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>,
spear-devel <spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3] ARM: SPEAr600: Add device-tree support to SPEAr600 boards
Date: Thu, 15 Mar 2012 16:33:29 +0530 [thread overview]
Message-ID: <4F61CC81.1020902@st.com> (raw)
In-Reply-To: <1331808632-22585-1-git-send-email-sr-ynQEQJNshbs@public.gmane.org>
On 3/15/2012 4:20 PM, Stefan Roese wrote:
> diff --git a/arch/arm/boot/dts/spear600.dtsi b/arch/arm/boot/dts/spear600.dtsi
> +/ {
> + compatible = "st,spear600";
> +
> + cpus {
> + cpu@0 {
> + compatible = "arm,arm926ejs";
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0x40000000>; /* Real value updated by U-Boot */
> + };
> +
> + ahb {
What is the significance of this name? As i see gpio/spi etc in this list,
which are on apb bus.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "simple-bus";
> + ranges;
> +
> + /* local/cpu GPIO */
> + gpio0: gpio@f0100000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xf0100000 0x1000>;
> + interrupt-parent = <&vic0>;
> + interrupts = <18>;
> + };
> +
> + /* basic GPIO */
> + gpio1: gpio@fc980000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xfc980000 0x1000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <19>;
> + };
> +
> + /* appl GPIO */
> + gpio2: gpio@d8100000 {
> + #gpio-cells = <2>;
> + compatible = "arm,pl061", "arm,primecell";
> + gpio-controller;
> + reg = <0xd8100000 0x1000>;
> + interrupt-parent = <&vic1>;
> + interrupts = <4>;
> + };
> +
> +};
> diff --git a/arch/arm/mach-spear6xx/clock.c b/arch/arm/mach-spear6xx/clock.c
> index ac70e0d..358f280 100644
> --- a/arch/arm/mach-spear6xx/clock.c
> +++ b/arch/arm/mach-spear6xx/clock.c
> @@ -641,8 +641,8 @@ static struct clk_lookup spear_clk_lookups[] = {
> { .con_id = "gpt0_synth_clk", .clk = &gpt0_synth_clk},
> { .con_id = "gpt2_synth_clk", .clk = &gpt2_synth_clk},
> { .con_id = "gpt3_synth_clk", .clk = &gpt3_synth_clk},
> - { .dev_id = "uart0", .clk = &uart0_clk},
> - { .dev_id = "uart1", .clk = &uart1_clk},
> + { .dev_id = "d0000000.serial", .clk = &uart0_clk},
> + { .dev_id = "d0080000.serial", .clk = &uart1_clk},
I didn't got Jean's comment at that time, but now it is ultra clear.
Acked-by: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
--
viresh
next prev parent reply other threads:[~2012-03-15 11:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 10:50 [PATCH v3] ARM: SPEAr600: Add device-tree support to SPEAr600 boards Stefan Roese
2012-03-15 10:50 ` Stefan Roese
2012-03-15 11:03 ` Viresh Kumar [this message]
2012-03-15 11:03 ` Viresh Kumar
2012-03-15 11:40 ` Arnd Bergmann
2012-03-15 11:40 ` Arnd Bergmann
2012-03-16 4:02 ` Viresh Kumar
2012-03-16 4:02 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F61CC81.1020902@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.