Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines

[Stefan Weil <sw@weilnetz.de>]

Am 05.03.2012 18:40, schrieb Paolo Bonzini:
> Conversion to coroutines simplifies the code and removes the need to
> duplicate common features of the block layer. Each step in the conversion
> is detailed in the corresponding commit message.
>
> Tested with qemu-iotests.
>
> Paolo Bonzini (7):
> vdi: basic conversion to coroutines
> vdi: move end-of-I/O handling at the end
> vdi: merge aio_read_cb and aio_write_cb into callers
> vdi: move aiocb fields to locals
> vdi: leave bounce buffering to block layer
> vdi: do not create useless iovecs
> vdi: change goto to loop
>
> block/vdi.c | 421 +++++++++++++-------------------------------------
> 2 files changed, 108 insertions(+), 317 deletions(-)

Acked-by: Stefan Weil <sw@weilnetz.de>

Kevin, could you please add Paolo's patches to your block queue?

I did not review each single patch in detail, but the resulting
code looks sane and much better (and shorter) than the current code
(a little like my original code before I had to add asynchronous
I/O support).

As Paolo already tested with qemu-iotests, I did not re-run those
tests.

Thanks,
Stefan W.