From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: sw@weilnetz.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer
Date: Fri, 16 Mar 2012 10:54:13 +0100 [thread overview]
Message-ID: <4F630DC5.7010204@redhat.com> (raw)
In-Reply-To: <1330969225-25287-6-git-send-email-pbonzini@redhat.com>
Am 05.03.2012 18:40, schrieb Paolo Bonzini:
> vdi.c really works as if it implemented bdrv_read and bdrv_write.
> However, because only vector I/O is supported by the asynchronous
> callbacks, it went through extra pain to bounce-buffer the I/O.
> With the conversion to coroutines bdrv_read and bdrv_write are now
> asynchronous, so they can be handled by the block layer now that the
> format is coroutine-based.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
In the long run, the right thing to do would be to convert VDI to deal
with vectored I/O, of course. Stefan, maybe you want to do that on top.
It's not that hard, I did it for qcow2 a while ago.
Kevin
next prev parent reply other threads:[~2012-03-16 9:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:40 [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 1/7] vdi: basic conversion " Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 2/7] vdi: move end-of-I/O handling at the end Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 3/7] vdi: merge aio_read_cb and aio_write_cb into callers Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 4/7] vdi: move aiocb fields to locals Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer Paolo Bonzini
2012-03-16 9:54 ` Kevin Wolf [this message]
2012-03-05 17:40 ` [Qemu-devel] [PATCH 6/7] vdi: do not create useless iovecs Paolo Bonzini
2012-03-05 17:40 ` [Qemu-devel] [PATCH 7/7] vdi: change goto to loop Paolo Bonzini
2012-03-15 21:28 ` [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines Stefan Weil
2012-03-16 9:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F630DC5.7010204@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.