From: Arjan van de Ven <arjan@linux.intel.com>
To: Colin Cross <ccross@android.com>
Cc: Kevin Hilman <khilman@ti.com>, Len Brown <len.brown@intel.com>,
Kay Sievers <kay.sievers@vrfy.org>,
linux-kernel@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
linux-pm@lists.linux-foundation.org,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 3/5] cpuidle: add support for states that affect multiple cpus
Date: Thu, 15 Mar 2012 18:52:05 -0700 [thread overview]
Message-ID: <4F629CC5.60402@linux.intel.com> (raw)
In-Reply-To: <CAMbhsRS3J2vruru8i4r1-cB9aJLYW9y1bP0vv7=L3q1JP77ttg@mail.gmail.com>
On 3/15/2012 5:20 PM, Colin Cross wrote:
> Oops, dropped the atomic_dec when I merged from two separate functions
> for up and down to a single function that takes a bool.
generally in Linux we tend to not like "multiplexer" common functions
like this.
my suggestion: make your current function a __ prefixed one, then
provide 2 small inlines that call the __ one...
WARNING: multiple messages have this Message-ID (diff)
From: arjan@linux.intel.com (Arjan van de Ven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/5] cpuidle: add support for states that affect multiple cpus
Date: Thu, 15 Mar 2012 18:52:05 -0700 [thread overview]
Message-ID: <4F629CC5.60402@linux.intel.com> (raw)
In-Reply-To: <CAMbhsRS3J2vruru8i4r1-cB9aJLYW9y1bP0vv7=L3q1JP77ttg@mail.gmail.com>
On 3/15/2012 5:20 PM, Colin Cross wrote:
> Oops, dropped the atomic_dec when I merged from two separate functions
> for up and down to a single function that takes a bool.
generally in Linux we tend to not like "multiplexer" common functions
like this.
my suggestion: make your current function a __ prefixed one, then
provide 2 small inlines that call the __ one...
WARNING: multiple messages have this Message-ID (diff)
From: Arjan van de Ven <arjan@linux.intel.com>
To: Colin Cross <ccross@android.com>
Cc: Kevin Hilman <khilman@ti.com>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
Trinabh Gupta <g.trinabh@gmail.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Deepthi Dharwar <deepthi@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Amit Kucheria <amit.kucheria@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-pm@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv2 3/5] cpuidle: add support for states that affect multiple cpus
Date: Thu, 15 Mar 2012 18:52:05 -0700 [thread overview]
Message-ID: <4F629CC5.60402@linux.intel.com> (raw)
In-Reply-To: <CAMbhsRS3J2vruru8i4r1-cB9aJLYW9y1bP0vv7=L3q1JP77ttg@mail.gmail.com>
On 3/15/2012 5:20 PM, Colin Cross wrote:
> Oops, dropped the atomic_dec when I merged from two separate functions
> for up and down to a single function that takes a bool.
generally in Linux we tend to not like "multiplexer" common functions
like this.
my suggestion: make your current function a __ prefixed one, then
provide 2 small inlines that call the __ one...
next prev parent reply other threads:[~2012-03-16 1:52 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 18:29 [PATCHv2 0/5] coupled cpuidle state support Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` [PATCHv2 1/5] cpuidle: refactor out cpuidle_enter_state Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` [PATCHv2 2/5] cpuidle: fix error handling in __cpuidle_register_device Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` [PATCHv2 3/5] cpuidle: add support for states that affect multiple cpus Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-16 0:04 ` Kevin Hilman
2012-03-16 0:04 ` Kevin Hilman
2012-03-16 0:20 ` Colin Cross
2012-03-16 0:20 ` Colin Cross
2012-03-16 0:20 ` Colin Cross
2012-03-16 1:52 ` Arjan van de Ven [this message]
2012-03-16 1:52 ` Arjan van de Ven
2012-03-16 1:52 ` Arjan van de Ven
2012-03-17 12:29 ` Santosh Shilimkar
2012-03-17 12:29 ` Santosh Shilimkar
2012-03-17 12:29 ` Santosh Shilimkar
2012-03-17 19:21 ` Colin Cross
2012-03-17 19:21 ` Colin Cross
2012-03-17 19:21 ` Colin Cross
2012-03-18 7:18 ` Shilimkar, Santosh
2012-03-18 7:18 ` Shilimkar, Santosh
2012-03-18 7:18 ` Shilimkar, Santosh
2012-03-14 18:29 ` [PATCHv2 4/5] cpuidle: coupled: add parallel barrier function Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` [PATCHv2 5/5] cpuidle: coupled: add trace events Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-03-14 18:29 ` Colin Cross
2012-04-09 6:59 ` Santosh Shilimkar
2012-04-09 6:59 ` Santosh Shilimkar
2012-04-09 6:59 ` Santosh Shilimkar
2012-03-15 23:37 ` [PATCHv2 0/5] coupled cpuidle state support Colin Cross
2012-03-15 23:37 ` Colin Cross
2012-03-15 23:37 ` Colin Cross
2012-03-30 12:53 ` Santosh Shilimkar
2012-03-30 12:53 ` Santosh Shilimkar
2012-03-30 12:53 ` Santosh Shilimkar
2012-04-09 7:11 ` Santosh Shilimkar
2012-04-09 7:11 ` Santosh Shilimkar
2012-04-09 7:11 ` Santosh Shilimkar
2012-04-09 23:35 ` [linux-pm] " Kevin Hilman
2012-04-09 23:35 ` Kevin Hilman
2012-04-09 23:35 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F629CC5.60402@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=amit.kucheria@linaro.org \
--cc=ccross@android.com \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.