From: "Andreas Färber" <andreas.faerber@web.de>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/5] configure to set shell type
Date: Fri, 16 Mar 2012 13:36:11 +0100 [thread overview]
Message-ID: <4F6333BB.8020905@web.de> (raw)
In-Reply-To: <0CFFD8B6-FCF3-44BF-87E0-44729ED219B9@nowonline.co.uk>
Am 16.03.2012 13:20, schrieb Lee Essen:
>
> On 16 Mar 2012, at 12:14, Andreas Färber wrote:
>
>> Am 16.03.2012 13:02, schrieb Lee Essen:
>>>
>>> +echo "SHELL=$shell" >> $config_host_mak
>>
>> Why?
>>
>
> See patch 2/7 … there are several calls to tracetool that hardcode "sh" in the Makefile … again if
> the better solution is removing the bash requirement then this problem goes away completely.
My point is, there is already use of $(SHELL) in Makefile. So why do you
need to explicitly set it here? Such things need to be explained in the
commit message. Was the variable being used unassigned? Or are you
trying to use a non-GNU make?
The concept of using $(SHELL) in make seems valid. Dunno if there is an
easier, built-in way to execute a script in the current shell than
hardcoding some executable name that needs to be in the $PATH?
Andreas
next prev parent reply other threads:[~2012-03-16 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:02 [Qemu-devel] [PATCH 1/5] configure to set shell type Lee Essen
2012-03-16 12:14 ` Andreas Färber
2012-03-16 12:20 ` Lee Essen
2012-03-16 12:22 ` Lee Essen
2012-03-16 12:36 ` Andreas Färber [this message]
2012-03-16 12:15 ` Peter Maydell
2012-03-16 12:24 ` Andreas Färber
2012-03-16 12:35 ` Peter Maydell
2012-03-16 15:58 ` Eric Blake
2012-03-16 16:19 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6333BB.8020905@web.de \
--to=andreas.faerber@web.de \
--cc=lee.essen@nowonline.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.