From: "Cousson, Benoit" <b-cousson@ti.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, tony@atomide.com,
grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] omap: board file changes to support dynamic irq alloc
Date: Fri, 16 Mar 2012 14:46:28 +0100 [thread overview]
Message-ID: <4F634434.3080707@ti.com> (raw)
In-Reply-To: <1331900647-3508-1-git-send-email-tarun.kanti@ti.com>
Hi Tarun,
On 3/16/2012 1:24 PM, Tarun Kanti DebBarma wrote:
> These two patches incorporate changes to OMAP1 and OMAP2 platforms
> board files whereby older references to OMAP_GPIO_IRQ macro are
> now replaced with gpio_to_irq(), thereby getting rid of static
> irq references.
Thanks for the board fix / cleanup.
...
> arch/arm/mach-omap1/board-h2.c | 8 ++++----
> arch/arm/mach-omap1/board-h3.c | 8 ++++----
> arch/arm/mach-omap1/board-htcherald.c | 6 +++---
> arch/arm/mach-omap1/board-innovator.c | 4 ++--
> arch/arm/mach-omap1/board-nokia770.c | 1 +
> arch/arm/mach-omap1/board-osk.c | 12 ++++++------
> arch/arm/mach-omap1/board-palmte.c | 2 +-
> arch/arm/mach-omap1/board-palmtt.c | 2 +-
> arch/arm/mach-omap1/board-palmz71.c | 2 +-
> arch/arm/mach-omap1/board-voiceblue.c | 16 +++++++---------
> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> arch/arm/mach-omap2/board-4430sdp.c | 2 +-
> arch/arm/mach-omap2/board-apollon.c | 6 ++++--
> arch/arm/mach-omap2/board-devkit8000.c | 3 ++-
> arch/arm/mach-omap2/board-h4.c | 2 +-
> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
> arch/arm/mach-omap2/board-omap4panda.c | 2 +-
> arch/arm/mach-omap2/board-rx51-peripherals.c | 3 ++-
> arch/arm/mach-omap2/board-zoom-debugboard.c | 3 ++-
> arch/arm/mach-omap2/board-zoom-peripherals.c | 6 ++++--
> arch/arm/mach-omap2/common-board-devices.c | 2 +-
I guess, you should be able to remove even the MACRO definition?
diff --git a/arch/arm/plat-omap/include/plat/gpio.h b/arch/arm/plat-omap/include/plat/gpio.h
index 9e86ee0..d4df414 100644
--- a/arch/arm/plat-omap/include/plat/gpio.h
+++ b/arch/arm/plat-omap/include/plat/gpio.h
@@ -158,10 +158,6 @@
#define OMAP_MPUIO(nr) (OMAP_MAX_GPIO_LINES + (nr))
#define OMAP_GPIO_IS_MPUIO(nr) ((nr) >= OMAP_MAX_GPIO_LINES)
-#define OMAP_GPIO_IRQ(nr) (OMAP_GPIO_IS_MPUIO(nr) ? \
- IH_MPUIO_BASE + ((nr) & 0x0f) : \
- IH_GPIO_BASE + (nr))
-
#define METHOD_MPUIO 0
#define METHOD_GPIO_1510 1
#define METHOD_GPIO_1610 2
It will avoid that people use it going forward.
Regards,
Benoit
WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] omap: board file changes to support dynamic irq alloc
Date: Fri, 16 Mar 2012 14:46:28 +0100 [thread overview]
Message-ID: <4F634434.3080707@ti.com> (raw)
In-Reply-To: <1331900647-3508-1-git-send-email-tarun.kanti@ti.com>
Hi Tarun,
On 3/16/2012 1:24 PM, Tarun Kanti DebBarma wrote:
> These two patches incorporate changes to OMAP1 and OMAP2 platforms
> board files whereby older references to OMAP_GPIO_IRQ macro are
> now replaced with gpio_to_irq(), thereby getting rid of static
> irq references.
Thanks for the board fix / cleanup.
...
> arch/arm/mach-omap1/board-h2.c | 8 ++++----
> arch/arm/mach-omap1/board-h3.c | 8 ++++----
> arch/arm/mach-omap1/board-htcherald.c | 6 +++---
> arch/arm/mach-omap1/board-innovator.c | 4 ++--
> arch/arm/mach-omap1/board-nokia770.c | 1 +
> arch/arm/mach-omap1/board-osk.c | 12 ++++++------
> arch/arm/mach-omap1/board-palmte.c | 2 +-
> arch/arm/mach-omap1/board-palmtt.c | 2 +-
> arch/arm/mach-omap1/board-palmz71.c | 2 +-
> arch/arm/mach-omap1/board-voiceblue.c | 16 +++++++---------
> arch/arm/mach-omap2/board-2430sdp.c | 2 +-
> arch/arm/mach-omap2/board-4430sdp.c | 2 +-
> arch/arm/mach-omap2/board-apollon.c | 6 ++++--
> arch/arm/mach-omap2/board-devkit8000.c | 3 ++-
> arch/arm/mach-omap2/board-h4.c | 2 +-
> arch/arm/mach-omap2/board-omap3evm.c | 2 +-
> arch/arm/mach-omap2/board-omap4panda.c | 2 +-
> arch/arm/mach-omap2/board-rx51-peripherals.c | 3 ++-
> arch/arm/mach-omap2/board-zoom-debugboard.c | 3 ++-
> arch/arm/mach-omap2/board-zoom-peripherals.c | 6 ++++--
> arch/arm/mach-omap2/common-board-devices.c | 2 +-
I guess, you should be able to remove even the MACRO definition?
diff --git a/arch/arm/plat-omap/include/plat/gpio.h b/arch/arm/plat-omap/include/plat/gpio.h
index 9e86ee0..d4df414 100644
--- a/arch/arm/plat-omap/include/plat/gpio.h
+++ b/arch/arm/plat-omap/include/plat/gpio.h
@@ -158,10 +158,6 @@
#define OMAP_MPUIO(nr) (OMAP_MAX_GPIO_LINES + (nr))
#define OMAP_GPIO_IS_MPUIO(nr) ((nr) >= OMAP_MAX_GPIO_LINES)
-#define OMAP_GPIO_IRQ(nr) (OMAP_GPIO_IS_MPUIO(nr) ? \
- IH_MPUIO_BASE + ((nr) & 0x0f) : \
- IH_GPIO_BASE + (nr))
-
#define METHOD_MPUIO 0
#define METHOD_GPIO_1510 1
#define METHOD_GPIO_1610 2
It will avoid that people use it going forward.
Regards,
Benoit
next prev parent reply other threads:[~2012-03-16 13:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 12:24 [PATCH 0/2] omap: board file changes to support dynamic irq alloc Tarun Kanti DebBarma
2012-03-16 12:24 ` Tarun Kanti DebBarma
2012-03-16 12:24 ` [PATCH 1/2] omap1/board-files: fix OMAP_GPIO_IRQ usage with gpio_to_irq() Tarun Kanti DebBarma
2012-03-16 12:24 ` Tarun Kanti DebBarma
2012-03-16 12:24 ` [PATCH 2/2] omap2plus/board-files: " Tarun Kanti DebBarma
2012-03-16 12:24 ` Tarun Kanti DebBarma
2012-03-16 13:46 ` Cousson, Benoit [this message]
2012-03-16 13:46 ` [PATCH 0/2] omap: board file changes to support dynamic irq alloc Cousson, Benoit
2012-03-16 13:52 ` DebBarma, Tarun Kanti
2012-03-16 13:52 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F634434.3080707@ti.com \
--to=b-cousson@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.