Re: [Qemu-devel] [PATCH v6 2/6] Introduce "save_devices"

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

On 03/15/2012 02:34 PM, Luiz Capitulino wrote:
> On Thu, 15 Mar 2012 15:16:15 -0500
> Anthony Liguori <anthony@codemonkey.ws> wrote:
> 
>> On 03/15/2012 01:19 PM, Stefano Stabellini wrote:
>>> - add an "is_ram" flag to SaveStateEntry;
>>>
>>> - register_savevm_live sets is_ram for live_savevm devices;
>>>
>>> - introduce a "save_devices" QAPI command that can be used to save
>>> the state of all devices, but not the RAM or the block devices of the
>>> VM.
>>>

>>> +SQMP
>>> +save_devices
>>> +-------
>>> +
>>> +Save the state of all devices to file. The RAM and the block devices
>>> +of the VM are not saved by this command.
>>> +
>>> +Arguments:
>>> +
>>> +- "filename": the file to save the state of the devices to as binary
>>> +data. See save_devices.txt for a description of the binary format.
>>> +
>>> +Example:
>>> +
>>> +->  { "execute": "save_devices", "arguments": { "filename": "/tmp/save" } }

Why are we adding yet another command without support for passing in an
fd instead of having qemu open the file name?  Libvirt really does want
to move to an ability to pass in fds, and the more commands we add that
open files, the harder converting them all will be.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]