All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Alexander Graf <agraf@suse.de>, David Gibson <dwg@au1.ibm.com>
Subject: Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings
Date: Sun, 18 Mar 2012 10:23:46 +0000	[thread overview]
Message-ID: <4F65B7B2.7080207@redhat.com> (raw)
In-Reply-To: <1331884552.3105.163.camel@pasglop>

On 03/16/2012 09:55 AM, Benjamin Herrenschmidt wrote:
> This is necessary for qemu to be able to pass the right information
> to the guest, as the supported sizes and encodings can vary depending
> on the machine, the type of KVM used (PR vs HV) and the version of KVM
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Please comment ASAP. I'm tired of the qemu side never working properly
> because of that and our out-of-tree nasty patches we've been carrying
> internally, so I'd like to get something like that in real quick :-)
>
> I have the qemu side patches that use this to generate the appropriate
> device-tree when available, and use heuristics for the fallback. I'll
> post them later, let's agree on the kernel interfaces first.
>
> The heuristics work as long as we have a reasonable guarantee that this
> kernel patch will get in -before- any patch that enables the PVINFO
> ioctl on "HV" KVM, that way I can rely on the later not working as
> a way to differenciate PR and HV KVM if this new ioctl is not supported. 
>
> Note: We probably want an other ioctl for getting other type of
> MMU info, such as whether we support 1T segments etc... but I didn't
> want to try to kill to many birds at once and end up in bike shed
> painting on the mailing list for the next 6 month...
>
> Cheers,
> Ben.
>
>  arch/powerpc/include/asm/kvm_ppc.h |    3 ++-
>  arch/powerpc/kvm/book3s_hv.c       |   35 +++++++++++++++++++++++++++++++++++
>  arch/powerpc/kvm/book3s_pr.c       |   22 ++++++++++++++++++++++
>  arch/powerpc/kvm/powerpc.c         |   18 +++++++++++++++++-
>  include/linux/kvm.h                |   29 +++++++++++++++++++++++++++++
>  5 files changed, 105 insertions(+), 2 deletions(-)
>

-ENODOCS

-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Alexander Graf <agraf@suse.de>, David Gibson <dwg@au1.ibm.com>
Subject: Re: [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings
Date: Sun, 18 Mar 2012 12:23:46 +0200	[thread overview]
Message-ID: <4F65B7B2.7080207@redhat.com> (raw)
In-Reply-To: <1331884552.3105.163.camel@pasglop>

On 03/16/2012 09:55 AM, Benjamin Herrenschmidt wrote:
> This is necessary for qemu to be able to pass the right information
> to the guest, as the supported sizes and encodings can vary depending
> on the machine, the type of KVM used (PR vs HV) and the version of KVM
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Please comment ASAP. I'm tired of the qemu side never working properly
> because of that and our out-of-tree nasty patches we've been carrying
> internally, so I'd like to get something like that in real quick :-)
>
> I have the qemu side patches that use this to generate the appropriate
> device-tree when available, and use heuristics for the fallback. I'll
> post them later, let's agree on the kernel interfaces first.
>
> The heuristics work as long as we have a reasonable guarantee that this
> kernel patch will get in -before- any patch that enables the PVINFO
> ioctl on "HV" KVM, that way I can rely on the later not working as
> a way to differenciate PR and HV KVM if this new ioctl is not supported. 
>
> Note: We probably want an other ioctl for getting other type of
> MMU info, such as whether we support 1T segments etc... but I didn't
> want to try to kill to many birds at once and end up in bike shed
> painting on the mailing list for the next 6 month...
>
> Cheers,
> Ben.
>
>  arch/powerpc/include/asm/kvm_ppc.h |    3 ++-
>  arch/powerpc/kvm/book3s_hv.c       |   35 +++++++++++++++++++++++++++++++++++
>  arch/powerpc/kvm/book3s_pr.c       |   22 ++++++++++++++++++++++
>  arch/powerpc/kvm/powerpc.c         |   18 +++++++++++++++++-
>  include/linux/kvm.h                |   29 +++++++++++++++++++++++++++++
>  5 files changed, 105 insertions(+), 2 deletions(-)
>

-ENODOCS

-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-03-18 10:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16  7:55 [PATCH/RFC] kvm/powerpc: Add new ioctl to retreive support page sizes and encodings Benjamin Herrenschmidt
2012-03-16  7:55 ` Benjamin Herrenschmidt
2012-03-18 10:23 ` Avi Kivity [this message]
2012-03-18 10:23   ` Avi Kivity
2012-03-18 20:47   ` Benjamin Herrenschmidt
2012-03-18 20:47     ` Benjamin Herrenschmidt
2012-03-18 21:05     ` Benjamin Herrenschmidt
2012-03-18 21:05       ` Benjamin Herrenschmidt
2012-03-18 21:16     ` Alexander Graf
2012-03-18 21:16       ` Alexander Graf
2012-03-18 21:22       ` Benjamin Herrenschmidt
2012-03-18 21:22         ` Benjamin Herrenschmidt
2012-03-19  9:18     ` Avi Kivity
2012-03-19  9:18       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F65B7B2.7080207@redhat.com \
    --to=avi@redhat.com \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=dwg@au1.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.