Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery

[Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>]

On 18/03/12 09:44, Avi Kivity wrote:

>> Hi Avi/Blue,
>>
>> I've just updated to git master and found that SPARC64 is broken
>> again; a git bisect shows the following commit causes this:
>>
>>
>> commit f3705d53296d78b14f5823472ae2add16a25a0a5
>> Author: Avi Kivity<avi@redhat.com>
>> Date:   Thu Mar 8 16:16:34 2012 +0200
>>
>>      memory: make phys_page_find() return an unadjusted section
>>
>>      We'd like to store the section index in the iotlb, so we can't
>>      adjust it before returning.  Return an unadjusted section and
>>      instead introduce section_addr(), which does the adjustment later.
>>
>>      Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>>
>> The symptom is that qemu-system-sparc64 segfaults immediately on
>> startup (note this is with an OpenBIOS image built from SVN r1048).
>> I've included a couple of backtraces below:
>>
>
> Please try the attached patch.
>
> If it fails, can you upload bios and disk images somewhere?

Hi Avi/Blue,

I can confirm that both patches work for me and enable SPARC64 to boot - 
Blue, what is the VGA display issue that you mention? I didn't see any 
display corruption when testing on both SPARC64 and PPC.

Upon inspection I see that Blue's patch seems to be a more of a global 
fix, whereas Avi's seems restricted to SPARC. Does that make Blue's 
patch a "better" solution since it will resolve the same undiscovered 
issue in other targets that make the same assumption?


Many thanks,

Mark.