From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery
Date: Sun, 18 Mar 2012 14:13:03 +0200 [thread overview]
Message-ID: <4F65D14F.2040605@redhat.com> (raw)
In-Reply-To: <CAAu8pHv-5ix--+p9QdqS3NwQHnV82UtPGgGsF5HP4EEx5BL4wg@mail.gmail.com>
On 03/18/2012 02:10 PM, Blue Swirl wrote:
> On Sun, Mar 18, 2012 at 12:08, Avi Kivity <avi@redhat.com> wrote:
> > On 03/18/2012 12:51 PM, Blue Swirl wrote:
> >> >
> >> > IMO, my patch is better. tlb_set_page() should not deal with offsets
> >> > within a page.
> >>
> >> It looks like all targets except Sparc32/64 mask the addresses before
> >> passing to tlb_set_page(), so I agree.
> >
> > Ok. Commit my patch then?
>
> I sent a different patch which masks incoming address earlier and
> removes unnecessary masking in other places.
My patch missed the "boot mode" thing. Does your patch fix it?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-18 12:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 2:01 [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery Mark Cave-Ayland
2012-03-18 9:44 ` Avi Kivity
2012-03-18 9:51 ` Blue Swirl
2012-03-18 10:31 ` Avi Kivity
2012-03-18 10:51 ` Blue Swirl
2012-03-18 11:03 ` Mark Cave-Ayland
2012-03-18 11:28 ` Blue Swirl
2012-03-18 12:08 ` Avi Kivity
2012-03-18 12:10 ` Blue Swirl
2012-03-18 12:13 ` Avi Kivity [this message]
2012-03-18 12:15 ` Blue Swirl
2012-03-18 15:36 ` Avi Kivity
2012-03-18 9:57 ` Blue Swirl
2012-03-18 10:29 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F65D14F.2040605@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.