From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] TRIVIAL: mmap.c: fix comment for __insert_vm_struct()
Date: Mon, 19 Mar 2012 09:33:24 +0900 [thread overview]
Message-ID: <4F667ED4.60204@jp.fujitsu.com> (raw)
In-Reply-To: <1331918590-2786-1-git-send-email-consul.kautuk@gmail.com>
(2012/03/17 2:23), Kautuk Consul wrote:
> The comment above __insert_vm_struct seems to suggest that this
> function is also going to link the VMA with the anon_vma, but
> this is not true.
> This function only links the VMA to the mm->mm_rb tree and the mm->mmap linked
> list.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
> ---
> mm/mmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index da15a79..6328a36 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -452,8 +452,8 @@ static void vma_link(struct mm_struct *mm, struct vm_area_struct *vma,
>
> /*
> * Helper for vma_adjust in the split_vma insert case:
> - * insert vm structure into list and rbtree and anon_vma,
> - * but it has already been inserted into prio_tree earlier.
> + * insert vm structure into list and rbtree, but it has
> + * already been inserted into prio_tree earlier.
> */
> static void __insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
> {
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Kautuk Consul <consul.kautuk@gmail.com>
Cc: Jiri Kosina <trivial@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] TRIVIAL: mmap.c: fix comment for __insert_vm_struct()
Date: Mon, 19 Mar 2012 09:33:24 +0900 [thread overview]
Message-ID: <4F667ED4.60204@jp.fujitsu.com> (raw)
In-Reply-To: <1331918590-2786-1-git-send-email-consul.kautuk@gmail.com>
(2012/03/17 2:23), Kautuk Consul wrote:
> The comment above __insert_vm_struct seems to suggest that this
> function is also going to link the VMA with the anon_vma, but
> this is not true.
> This function only links the VMA to the mm->mm_rb tree and the mm->mmap linked
> list.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
> ---
> mm/mmap.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index da15a79..6328a36 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -452,8 +452,8 @@ static void vma_link(struct mm_struct *mm, struct vm_area_struct *vma,
>
> /*
> * Helper for vma_adjust in the split_vma insert case:
> - * insert vm structure into list and rbtree and anon_vma,
> - * but it has already been inserted into prio_tree earlier.
> + * insert vm structure into list and rbtree, but it has
> + * already been inserted into prio_tree earlier.
> */
> static void __insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
> {
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
next prev parent reply other threads:[~2012-03-19 0:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 17:23 [PATCH 1/1] TRIVIAL: mmap.c: fix comment for __insert_vm_struct() Kautuk Consul
2012-03-16 17:23 ` Kautuk Consul
2012-03-19 0:33 ` KAMEZAWA Hiroyuki [this message]
2012-03-19 0:33 ` KAMEZAWA Hiroyuki
2012-03-19 23:16 ` Andrew Morton
2012-03-19 23:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F667ED4.60204@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=consul.kautuk@gmail.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.