From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-mips: Remove unused inline function
Date: Mon, 19 Mar 2012 13:43:58 +0100 [thread overview]
Message-ID: <4F672A0E.2090301@suse.de> (raw)
In-Reply-To: <4F672711.7030501@weilnetz.de>
Am 19.03.2012 13:31, schrieb Stefan Weil:
> Am 19.03.2012 13:17, schrieb Stefan Hajnoczi:
>> On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber <afaerber@suse.de>
>> wrote:
>>> Am 17.03.2012 13:00, schrieb Stefan Weil:
>>>> Function set_HILO is not needed anywhere.
>>>
>>> Does this cause any warnings? Given the state mips is currently in (TCG
>>> patches queuing), I'd suggest to hold this off for a bit, but I don't
>>> really mind either way.
>>>
>>> Commit message does not mention if this was never used in the first
>>> place or became unused during TCG conversion or some other refactoring?
>>
>> It doesn't cause any warning on my build here, so there's no strict
>> need for this patch.
>>
>> I have dropped the patch for now. Please resend if you want to get it
>> in and address Andreas' questions.
>
> the function was never used. It should be removed just to keep
> the code clean and free of unneeded functions. I noticed this
> function when I looked after the functions which follow
> (set_HIT0_LO, ...). Those functions are very similar, so I
> think set_HILO was the copy master for those functions
> (maybe used in a local code version whic was never committed).
Could you please check that it is not used by Richard Sandiford's,
Khansa Butt's and Jia Liu's patches? Then I'll happily ack.
>
> Static inline functions never create a gcc warning when they
> are unused, as far as I know. Maybe other tools like static code
> analysers raise a warning.
Sure, I was thinking of the static analysis tools you occasionally
posted patches for.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Remove unused inline function
Date: Mon, 19 Mar 2012 13:43:58 +0100 [thread overview]
Message-ID: <4F672A0E.2090301@suse.de> (raw)
In-Reply-To: <4F672711.7030501@weilnetz.de>
Am 19.03.2012 13:31, schrieb Stefan Weil:
> Am 19.03.2012 13:17, schrieb Stefan Hajnoczi:
>> On Mon, Mar 19, 2012 at 10:33 AM, Andreas Färber <afaerber@suse.de>
>> wrote:
>>> Am 17.03.2012 13:00, schrieb Stefan Weil:
>>>> Function set_HILO is not needed anywhere.
>>>
>>> Does this cause any warnings? Given the state mips is currently in (TCG
>>> patches queuing), I'd suggest to hold this off for a bit, but I don't
>>> really mind either way.
>>>
>>> Commit message does not mention if this was never used in the first
>>> place or became unused during TCG conversion or some other refactoring?
>>
>> It doesn't cause any warning on my build here, so there's no strict
>> need for this patch.
>>
>> I have dropped the patch for now. Please resend if you want to get it
>> in and address Andreas' questions.
>
> the function was never used. It should be removed just to keep
> the code clean and free of unneeded functions. I noticed this
> function when I looked after the functions which follow
> (set_HIT0_LO, ...). Those functions are very similar, so I
> think set_HILO was the copy master for those functions
> (maybe used in a local code version whic was never committed).
Could you please check that it is not used by Richard Sandiford's,
Khansa Butt's and Jia Liu's patches? Then I'll happily ack.
>
> Static inline functions never create a gcc warning when they
> are unused, as far as I know. Maybe other tools like static code
> analysers raise a warning.
Sure, I was thinking of the static analysis tools you occasionally
posted patches for.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-19 12:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 12:00 [Qemu-trivial] [PATCH] target-mips: Remove unused inline function Stefan Weil
2012-03-17 12:00 ` [Qemu-devel] " Stefan Weil
2012-03-19 10:33 ` [Qemu-trivial] " Andreas Färber
2012-03-19 10:33 ` Andreas Färber
2012-03-19 12:17 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-19 12:17 ` Stefan Hajnoczi
2012-03-19 12:31 ` [Qemu-trivial] " Stefan Weil
2012-03-19 12:31 ` Stefan Weil
2012-03-19 12:43 ` Andreas Färber [this message]
2012-03-19 12:43 ` Andreas Färber
2012-03-19 13:08 ` [Qemu-trivial] " Stefan Weil
2012-03-19 13:08 ` Stefan Weil
2012-04-23 19:59 ` [Qemu-trivial] " Stefan Weil
2012-03-19 11:02 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-19 11:02 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F672A0E.2090301@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.