From: Timur Tabi <b04825@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Aggrwal Poonam-B10812 <B10812@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Singh Sandeep-B37400 <B37400@freescale.com>
Subject: Re: [PATCH] Device Tree Bindings for Freescale TDM controller
Date: Mon, 19 Mar 2012 12:32:14 -0500 [thread overview]
Message-ID: <4F676D9E.6000609@freescale.com> (raw)
In-Reply-To: <4F676C9D.2070301@freescale.com>
Scott Wood wrote:
>> > Scott, are you suggesting that Poonam put a non-zero number in the DTS
>> > for clock-frequency? If so, then I don't think that's a good idea, if
>> > U-Boot will always override it.
> This is a device tree binding document, not U-Boot specific. It
> describes what Linux (or another OS) can expect to see, not how it gets
> there.
That doesn't really answer my question. We currently have many properties
that define a clock frequency, and the DTS sets them all to 0, with the
intent of having U-Boot update them. Now maybe these should all be
deleted, but it seems that setting them to a non-zero value is wrong,
because it might mislead people into thinking that the property is not
updated by U-Boot. When you see something like this:
clock-frequency = <0>;
It's pretty obvious that U-boot will fill it in.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <b04825-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Wood Scott-B07421
<B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Aggrwal Poonam-B10812
<B10812-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Singh Sandeep-B37400
<B37400-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] Device Tree Bindings for Freescale TDM controller
Date: Mon, 19 Mar 2012 12:32:14 -0500 [thread overview]
Message-ID: <4F676D9E.6000609@freescale.com> (raw)
In-Reply-To: <4F676C9D.2070301-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Scott Wood wrote:
>> > Scott, are you suggesting that Poonam put a non-zero number in the DTS
>> > for clock-frequency? If so, then I don't think that's a good idea, if
>> > U-Boot will always override it.
> This is a device tree binding document, not U-Boot specific. It
> describes what Linux (or another OS) can expect to see, not how it gets
> there.
That doesn't really answer my question. We currently have many properties
that define a clock frequency, and the DTS sets them all to 0, with the
intent of having U-Boot update them. Now maybe these should all be
deleted, but it seems that setting them to a non-zero value is wrong,
because it might mislead people into thinking that the property is not
updated by U-Boot. When you see something like this:
clock-frequency = <0>;
It's pretty obvious that U-boot will fill it in.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-03-19 17:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 1:30 [PATCH] Device Tree Bindings for Freescale TDM controller Poonam Aggrwal
2012-03-16 1:30 ` Poonam Aggrwal
2012-03-16 18:29 ` Scott Wood
2012-03-17 7:33 ` Aggrwal Poonam-B10812
2012-03-17 7:33 ` Aggrwal Poonam-B10812
2012-03-17 16:04 ` Tabi Timur-B04825
2012-03-17 16:04 ` Tabi Timur-B04825
2012-03-17 16:07 ` Tabi Timur-B04825
2012-03-17 16:07 ` Tabi Timur-B04825
2012-03-19 17:27 ` Scott Wood
2012-03-19 17:32 ` Timur Tabi [this message]
2012-03-19 17:32 ` Timur Tabi
2012-03-19 17:55 ` Scott Wood
2012-03-19 17:55 ` Scott Wood
2012-03-19 17:32 ` Scott Wood
2012-03-19 17:32 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F676D9E.6000609@freescale.com \
--to=b04825@freescale.com \
--cc=B07421@freescale.com \
--cc=B10812@freescale.com \
--cc=B37400@freescale.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.