From: Stephen Warren <swarren@wwwdotorg.org>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, kgene.kim@samsung.com,
linus.walleij@linaro.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface
Date: Mon, 19 Mar 2012 15:55:24 -0600 [thread overview]
Message-ID: <4F67AB4C.9040801@wwwdotorg.org> (raw)
In-Reply-To: <1331469965-28846-6-git-send-email-thomas.abraham@linaro.org>
On 03/11/2012 06:46 AM, Thomas Abraham wrote:
> The platform specific callback to setup the sdhci pin mux and pin config
> is removed and the pinctrl subsystem interface is used to setup the
> mux and config.
> @@ -643,8 +649,13 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> }
>
> /* Ensure we have minimal gpio selected CMD/CLK/Detect */
> - if (pdata->cfg_gpio)
> - pdata->cfg_gpio(pdev, pdata->max_width);
> + pstate = pdata->max_width ? "sdhci-pcfg8" : "sdhci-pcfg4";
If the driver is going to select a single state ("sdhci-pcfg8" or
"sdhci-pcfg4" above) at probe() time and never change it (which seems
quite reasonable for an SDHCI controller), then the driver should always
use state PINCTRL_STATE_DEFAULT, and it should be up to the board to set
up the mapping table such that PINCTRL_STATE_DEFAULT sets up the pins
for either 4-bit or 8-bit as appropriate for the board.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface
Date: Mon, 19 Mar 2012 15:55:24 -0600 [thread overview]
Message-ID: <4F67AB4C.9040801@wwwdotorg.org> (raw)
In-Reply-To: <1331469965-28846-6-git-send-email-thomas.abraham@linaro.org>
On 03/11/2012 06:46 AM, Thomas Abraham wrote:
> The platform specific callback to setup the sdhci pin mux and pin config
> is removed and the pinctrl subsystem interface is used to setup the
> mux and config.
> @@ -643,8 +649,13 @@ static int __devinit sdhci_s3c_probe(struct platform_device *pdev)
> }
>
> /* Ensure we have minimal gpio selected CMD/CLK/Detect */
> - if (pdata->cfg_gpio)
> - pdata->cfg_gpio(pdev, pdata->max_width);
> + pstate = pdata->max_width ? "sdhci-pcfg8" : "sdhci-pcfg4";
If the driver is going to select a single state ("sdhci-pcfg8" or
"sdhci-pcfg4" above) at probe() time and never change it (which seems
quite reasonable for an SDHCI controller), then the driver should always
use state PINCTRL_STATE_DEFAULT, and it should be up to the board to set
up the mapping table such that PINCTRL_STATE_DEFAULT sets up the pins
for either 4-bit or 8-bit as appropriate for the board.
next prev parent reply other threads:[~2012-03-19 21:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 12:46 [PATCH 0/5] pinctrl: add new Samsung pinctrl driver and add Exynos4 support Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-11 12:46 ` [PATCH 1/5] pinctrl: add samsung pinctrl and gpiolib driver Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-19 21:45 ` Stephen Warren
2012-03-19 21:45 ` Stephen Warren
2012-03-11 12:46 ` [PATCH 2/5] pinctrl: add exynos4 specific pins, groups, functions and gpio chip data Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-11 12:46 ` [PATCH 3/5] ARM: Exynos4: Add pinctrl devices and pin maps Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-11 21:17 ` Kukjin Kim
2012-03-11 21:17 ` Kukjin Kim
2012-03-12 4:22 ` Thomas Abraham
2012-03-12 4:22 ` Thomas Abraham
2012-03-11 12:46 ` [PATCH 4/5] ARM: Exynos: Enable pinctrl driver support for Origen board Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-11 12:46 ` [PATCH 5/5] mmc: sdhci-s3c: setup pins using pinctrl interface Thomas Abraham
2012-03-11 12:46 ` Thomas Abraham
2012-03-11 21:25 ` Kukjin Kim
2012-03-11 21:25 ` Kukjin Kim
2012-03-12 4:28 ` Thomas Abraham
2012-03-12 4:28 ` Thomas Abraham
2012-03-12 2:38 ` Kyungmin Park
2012-03-12 2:38 ` Kyungmin Park
2012-03-12 4:37 ` Thomas Abraham
2012-03-12 4:37 ` Thomas Abraham
2012-03-12 14:21 ` Mark Brown
2012-03-12 14:21 ` Mark Brown
2012-03-12 14:31 ` Thomas Abraham
2012-03-12 14:31 ` Thomas Abraham
2012-03-12 16:12 ` Mark Brown
2012-03-12 16:12 ` Mark Brown
2012-03-19 21:55 ` Stephen Warren [this message]
2012-03-19 21:55 ` Stephen Warren
2012-03-13 10:13 ` [PATCH 0/5] pinctrl: add new Samsung pinctrl driver and add Exynos4 support Linus Walleij
2012-03-13 10:13 ` Linus Walleij
2012-03-13 10:18 ` Thomas Abraham
2012-03-13 10:18 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F67AB4C.9040801@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=kgene.kim@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.