[PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[santosh nayak]

From: Santosh Nayak <santoshprasadnayak@gmail.com>

We need to add error handler if kzalloc fails to allocate and initialize.
Otherwise it may lead to Null derefernce error in 
'pm8001_chip_get_nvmd_req()'.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
 drivers/scsi/pm8001/pm8001_init.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 36efaa7..fdce28e 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
 	payload.minor_function = 0;
 	payload.length = 128;
 	payload.func_specific = kzalloc(128, GFP_KERNEL);
+	if (unlikely(!payload.func_specific)) {
+		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
+		return;
+	}
 	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
 	wait_for_completion(&completion);
 	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
-- 
1.7.4.4

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[James Bottomley]

On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> We need to add error handler if kzalloc fails to allocate and initialize.
> Otherwise it may lead to Null derefernce error in 
> 'pm8001_chip_get_nvmd_req()'.

It's a GFP_KERNEL allocation.  They sleep until memory is available
(__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.

James

[PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[santosh nayak]

From: Santosh Nayak <santoshprasadnayak@gmail.com>

We need to add error handler if kzalloc fails to allocate and initialize.
Otherwise it may lead to Null derefernce error in 
'pm8001_chip_get_nvmd_req()'.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
 drivers/scsi/pm8001/pm8001_init.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
index 36efaa7..fdce28e 100644
--- a/drivers/scsi/pm8001/pm8001_init.c
+++ b/drivers/scsi/pm8001/pm8001_init.c
@@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
 	payload.minor_function = 0;
 	payload.length = 128;
 	payload.func_specific = kzalloc(128, GFP_KERNEL);
+	if (unlikely(!payload.func_specific)) {
+		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
+		return;
+	}
 	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
 	wait_for_completion(&completion);
 	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
-- 
1.7.4.4

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Wed, Mar 21, 2012 at 08:49:45AM +0000, James Bottomley wrote:
> On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > 
> > We need to add error handler if kzalloc fails to allocate and initialize.
> > Otherwise it may lead to Null derefernce error in 
> > 'pm8001_chip_get_nvmd_req()'.
> 
> It's a GFP_KERNEL allocation.  They sleep until memory is available
> (__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.
> 

That's not right at all.  Only __GFP_NOFAIL allocations don't need
to be checked.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Wed, Mar 21, 2012 at 08:49:45AM +0000, James Bottomley wrote:
> On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > 
> > We need to add error handler if kzalloc fails to allocate and initialize.
> > Otherwise it may lead to Null derefernce error in 
> > 'pm8001_chip_get_nvmd_req()'.
> 
> It's a GFP_KERNEL allocation.  They sleep until memory is available
> (__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.
> 

That's not right at all.  Only __GFP_NOFAIL allocations don't need
to be checked.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[James Bottomley]

On Wed, 2012-03-21 at 11:58 +0300, Dan Carpenter wrote:
> On Wed, Mar 21, 2012 at 08:49:45AM +0000, James Bottomley wrote:
> > On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
> > > From: Santosh Nayak <santoshprasadnayak@gmail.com>
> > > 
> > > We need to add error handler if kzalloc fails to allocate and initialize.
> > > Otherwise it may lead to Null derefernce error in 
> > > 'pm8001_chip_get_nvmd_req()'.
> > 
> > It's a GFP_KERNEL allocation.  They sleep until memory is available
> > (__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.
> > 
> 
> That's not right at all.  Only __GFP_NOFAIL allocations don't need
> to be checked.

Ah, right, that's the option I was thinking of.  __GFP_WAIT may fail if
we're in direct reclaim or the oom killer gets activated.

James

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[walter harms]

Am 21.03.2012 11:11, schrieb James Bottomley:
> On Wed, 2012-03-21 at 11:58 +0300, Dan Carpenter wrote:
>> On Wed, Mar 21, 2012 at 08:49:45AM +0000, James Bottomley wrote:
>>> On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
>>>> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>>>>
>>>> We need to add error handler if kzalloc fails to allocate and initialize.
>>>> Otherwise it may lead to Null derefernce error in 
>>>> 'pm8001_chip_get_nvmd_req()'.
>>>
>>> It's a GFP_KERNEL allocation.  They sleep until memory is available
>>> (__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.
>>>
>>
>> That's not right at all.  Only __GFP_NOFAIL allocations don't need
>> to be checked.
> 
> Ah, right, that's the option I was thinking of.  __GFP_WAIT may fail if
> we're in direct reclaim or the oom killer gets activated.
> 

I think it is ok to do it anytime. It is useles in the __GFP_NOFAIL case,
but it is more easy to check: avoid exceptions from the rule !

re,
 wh

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Wed, Mar 21, 2012 at 11:50:00AM +0100, walter harms wrote:
> 
> 
> Am 21.03.2012 11:11, schrieb James Bottomley:
> > On Wed, 2012-03-21 at 11:58 +0300, Dan Carpenter wrote:
> >> On Wed, Mar 21, 2012 at 08:49:45AM +0000, James Bottomley wrote:
> >>> On Wed, 2012-03-21 at 14:08 +0530, santosh nayak wrote:
> >>>> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> >>>>
> >>>> We need to add error handler if kzalloc fails to allocate and initialize.
> >>>> Otherwise it may lead to Null derefernce error in 
> >>>> 'pm8001_chip_get_nvmd_req()'.
> >>>
> >>> It's a GFP_KERNEL allocation.  They sleep until memory is available
> >>> (__GFP_WAIT).  It's GFP_ATOMIC that can return NULL.
> >>>
> >>
> >> That's not right at all.  Only __GFP_NOFAIL allocations don't need
> >> to be checked.
> > 
> > Ah, right, that's the option I was thinking of.  __GFP_WAIT may fail if
> > we're in direct reclaim or the oom killer gets activated.
> > 
> 
> I think it is ok to do it anytime. It is useles in the __GFP_NOFAIL case,
> but it is more easy to check: avoid exceptions from the rule !

That's nonsense.  Code deliberately.  I feel like I spend too much
time removing bogus NULL checks already.  Don't encourage people to
add them.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Mark Salyzyn]

ACK based on James' concerned being extinguished by Dan's comment

Sincerely -- Mark Salyzyn

On Mar 21, 2012, at 4:38 AM, santosh nayak wrote:

> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> We need to add error handler if kzalloc fails to allocate and initialize.
> Otherwise it may lead to Null derefernce error in 
> 'pm8001_chip_get_nvmd_req()'.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 36efaa7..fdce28e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
> 	payload.minor_function = 0;
> 	payload.length = 128;
> 	payload.func_specific = kzalloc(128, GFP_KERNEL);
> +	if (unlikely(!payload.func_specific)) {
> +		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
> +		return;
> +	}
> 	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
> 	wait_for_completion(&completion);
> 	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> -- 
> 1.7.4.4
> 

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Mark Salyzyn]

ACK based on James' concerned being extinguished by Dan's comment

Sincerely -- Mark Salyzyn

On Mar 21, 2012, at 4:38 AM, santosh nayak wrote:

> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> We need to add error handler if kzalloc fails to allocate and initialize.
> Otherwise it may lead to Null derefernce error in 
> 'pm8001_chip_get_nvmd_req()'.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
> drivers/scsi/pm8001/pm8001_init.c |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 36efaa7..fdce28e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct pm8001_hba_info *pm8001_ha)
> 	payload.minor_function = 0;
> 	payload.length = 128;
> 	payload.func_specific = kzalloc(128, GFP_KERNEL);
> +	if (unlikely(!payload.func_specific)) {
> +		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
> +		return;
> +	}
> 	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
> 	wait_for_completion(&completion);
> 	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> -- 
> 1.7.4.4
> 

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Jack Wang]

Based on all comment from others, I ACK this patch.
Thanks.

Acked-by: Jack Wang <jack_wang@usish.com>

> 
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> We need to add error handler if kzalloc fails to allocate and initialize.
> Otherwise it may lead to Null derefernce error in
> 'pm8001_chip_get_nvmd_req()'.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
>  drivers/scsi/pm8001/pm8001_init.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c
> b/drivers/scsi/pm8001/pm8001_init.c
> index 36efaa7..fdce28e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct
pm8001_hba_info
> *pm8001_ha)
>  	payload.minor_function = 0;
>  	payload.length = 128;
>  	payload.func_specific = kzalloc(128, GFP_KERNEL);
> +	if (unlikely(!payload.func_specific)) {
> +		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
> +		return;
> +	}
>  	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
>  	wait_for_completion(&completion);
>  	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> --
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [SCSI] pm8001: Add error handler in pm8001_init_sas_add() if kzalloc fails.

[Jack Wang]

Based on all comment from others, I ACK this patch.
Thanks.

Acked-by: Jack Wang <jack_wang@usish.com>

> 
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> We need to add error handler if kzalloc fails to allocate and initialize.
> Otherwise it may lead to Null derefernce error in
> 'pm8001_chip_get_nvmd_req()'.
> 
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
> ---
>  drivers/scsi/pm8001/pm8001_init.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/pm8001/pm8001_init.c
> b/drivers/scsi/pm8001/pm8001_init.c
> index 36efaa7..fdce28e 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -519,6 +519,10 @@ static void pm8001_init_sas_add(struct
pm8001_hba_info
> *pm8001_ha)
>  	payload.minor_function = 0;
>  	payload.length = 128;
>  	payload.func_specific = kzalloc(128, GFP_KERNEL);
> +	if (unlikely(!payload.func_specific)) {
> +		printk(KERN_ERR "%s: failed to alloc memory\n", __func__);
> +		return;
> +	}
>  	PM8001_CHIP_DISP->get_nvmd_req(pm8001_ha, &payload);
>  	wait_for_completion(&completion);
>  	for (i = 0; i < pm8001_ha->chip->n_phy; i++) {
> --
> 1.7.4.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html