From: "Crístian Viana" <vianac@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew
Date: Wed, 21 Mar 2012 14:14:20 -0300 [thread overview]
Message-ID: <4F6A0C6C.4070004@linux.vnet.ibm.com> (raw)
In-Reply-To: <jkbqst$bku$1@dough.gmane.org>
On 21-03-2012 03:02, Paolo Bonzini wrote:
> This piece of code from the previous if:
>
> if (!strcmp(value, "slew")) {
> static GlobalProperty slew_lost_ticks[] = {
> {
> .driver = "mc146818rtc",
> .property = "lost_tick_policy",
> .value = "slew",
> },
> { /* end of list */ }
> };
>
> qdev_prop_register_global_list(slew_lost_ticks);
>
> needs to be adjusted and moved to the "if (!strmp(value, "none"))" branch.
Thanks, Paolo! I sent a version 3 of these patches with the changes you
suggested.
--
Best regards,
Crístian.
prev parent reply other threads:[~2012-03-21 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 20:59 [Qemu-devel] [PATCH v2 1/2] Force timedrift=none on previous machines Crístian Viana
2012-03-20 20:59 ` [Qemu-devel] [PATCH v2 2/2] Change timedrift default value to slew Crístian Viana
2012-03-21 6:02 ` Paolo Bonzini
2012-03-21 17:14 ` Crístian Viana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A0C6C.4070004@linux.vnet.ibm.com \
--to=vianac@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.