From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
peter.portante@redhat.com
Subject: Re: [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes
Date: Thu, 22 Mar 2012 01:05:34 +0100 [thread overview]
Message-ID: <4F6A6CCE.4000904@redhat.com> (raw)
In-Reply-To: <1332363767-21327-1-git-send-email-peter.portante@redhat.com>
Il 21/03/2012 22:02, Peter Portante ha scritto:
> Hi Folks,
>
> Please forgive me if you find these changes are annoying, as I am trying to
> learn the ropes of patch submission with git ahead of making a real patch.
>
> While working on the code, I found that scripts/checkpatch.pl will flag lines
> that I am changing as not adhereing to the codeing standard due to
> pre-existing coding violations. So I figured I could learn a bit about how to
> submit patches by fixing these files I will be touching before submitting the
> code changes.
I think slirp is a mess and it's not worth doing this kind of sweeping
change. Just ignore checkpatch output for slirp.
For the others, the changes are pretty small so they could be doable.
If you want to change them then please also add braces around if statements.
In any case, your patch submission workflow seems to be fine. :P
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>,
peter.portante@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes
Date: Thu, 22 Mar 2012 01:05:34 +0100 [thread overview]
Message-ID: <4F6A6CCE.4000904@redhat.com> (raw)
In-Reply-To: <1332363767-21327-1-git-send-email-peter.portante@redhat.com>
Il 21/03/2012 22:02, Peter Portante ha scritto:
> Hi Folks,
>
> Please forgive me if you find these changes are annoying, as I am trying to
> learn the ropes of patch submission with git ahead of making a real patch.
>
> While working on the code, I found that scripts/checkpatch.pl will flag lines
> that I am changing as not adhereing to the codeing standard due to
> pre-existing coding violations. So I figured I could learn a bit about how to
> submit patches by fixing these files I will be touching before submitting the
> code changes.
I think slirp is a mess and it's not worth doing this kind of sweeping
change. Just ignore checkpatch output for slirp.
For the others, the changes are pretty small so they could be doable.
If you want to change them then please also add braces around if statements.
In any case, your patch submission workflow seems to be fine. :P
Paolo
next prev parent reply other threads:[~2012-03-22 0:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:02 [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes Peter Portante
2012-03-21 21:02 ` [Qemu-devel] " Peter Portante
2012-03-21 21:02 ` [Qemu-trivial] [PATCH 1/4] More whitespace cleanup in preparation for future commits Peter Portante
2012-03-21 21:02 ` [Qemu-devel] " Peter Portante
2012-03-21 21:02 ` [Qemu-trivial] [PATCH 2/4] More work to fix up the formatting and the whitespace of this module to conform to the coding standard Peter Portante
2012-03-21 21:02 ` [Qemu-devel] " Peter Portante
2012-03-21 21:02 ` [Qemu-trivial] [PATCH 3/4] And some final work to complete the coding style upgrade, missed by the previous commit Peter Portante
2012-03-21 21:02 ` [Qemu-devel] " Peter Portante
2012-03-21 21:02 ` [Qemu-trivial] [PATCH 4/4] Yet another missed use of tabs Peter Portante
2012-03-21 21:02 ` [Qemu-devel] " Peter Portante
2012-03-22 0:05 ` Paolo Bonzini [this message]
2012-03-22 0:05 ` [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes Paolo Bonzini
2012-03-22 10:27 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-22 10:27 ` [Qemu-devel] " Stefan Hajnoczi
2012-03-22 13:28 ` Jan Kiszka
2012-03-22 13:28 ` [Qemu-devel] " Jan Kiszka
2012-03-22 10:57 ` [Qemu-trivial] " Peter Maydell
2012-03-22 10:57 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6A6CCE.4000904@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.portante@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.