All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path
Date: Thu, 22 Mar 2012 15:37:39 +0100	[thread overview]
Message-ID: <4F6B3933.20708@redhat.com> (raw)
In-Reply-To: <4F6B30A8.6060903@suse.de>

  Hi,

>> +            .driver   = "USB",
>> +            .property = "full-path",
>> +            .value    = "no",
> 
> This touches on our "favorite" bit/bool topic again. While I agree that
> "no" makes sense for a property of that name, the current code still
> expects "on" and "off". In particular, "yes" would not work as expected.

"no" *does* work as expected though, at least it survived my tests,
thats why I didn't notice.

I can s/no/off/ for consistency, no problem.  Merging your yes/no patch
is fine with me too.

cheers,
  Gerd

  reply	other threads:[~2012-03-22 14:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 12:07 [Qemu-devel] [PATCH] usb/vmstate: add parent dev path Gerd Hoffmann
2012-03-22 12:17 ` Paolo Bonzini
2012-03-22 14:01 ` Andreas Färber
2012-03-22 14:37   ` Gerd Hoffmann [this message]
2012-03-22 15:12     ` Andreas Färber
2012-03-28 22:08       ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6B3933.20708@redhat.com \
    --to=kraxel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.