All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	rds-devel@oss.oracle.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] RDS: use gfp flags from caller in conn_alloc()
Date: Thu, 22 Mar 2012 15:19:50 +0000	[thread overview]
Message-ID: <4F6B4316.5050508@oracle.com> (raw)
In-Reply-To: <20120322064409.GE7369@elgon.mountain>

On 3/22/2012 1:44 AM, Dan Carpenter wrote:
> We should be using the gfp flags the caller specified here, instead of
> GFP_KERNEL.  I think this might be a bugfix, depending on the value of
> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
> rds_sendmsg().  Otherwise, it's just a cleanup.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>


WARNING: multiple messages have this Message-ID (diff)
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	rds-devel@oss.oracle.com, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] RDS: use gfp flags from caller in conn_alloc()
Date: Thu, 22 Mar 2012 10:19:50 -0500	[thread overview]
Message-ID: <4F6B4316.5050508@oracle.com> (raw)
In-Reply-To: <20120322064409.GE7369@elgon.mountain>

On 3/22/2012 1:44 AM, Dan Carpenter wrote:
> We should be using the gfp flags the caller specified here, instead of
> GFP_KERNEL.  I think this might be a bugfix, depending on the value of
> "sock->sk->sk_allocation" when we call rds_conn_create_outgoing() in
> rds_sendmsg().  Otherwise, it's just a cleanup.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>

  reply	other threads:[~2012-03-22 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22  6:44 [patch] RDS: use gfp flags from caller in conn_alloc() Dan Carpenter
2012-03-22  6:44 ` Dan Carpenter
2012-03-22 15:19 ` Venkat Venkatsubra [this message]
2012-03-22 15:19   ` Venkat Venkatsubra
2012-03-22 23:30   ` David Miller
2012-03-22 23:30     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6B4316.5050508@oracle.com \
    --to=venkat.x.venkatsubra@oracle.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.