From: Stefano Babic <sbabic@denx.de>
To: Kyle Manna <kyle.manna@fuel7.com>
Cc: Stefano Babic <sbabic@denx.de>, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>,
Kevin Hilman <khilman@ti.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Benoit Cousson <b-cousson@ti.com>,
linux-kernel@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3
Date: Thu, 22 Mar 2012 18:11:59 +0100 [thread overview]
Message-ID: <4F6B5D5F.90206@denx.de> (raw)
In-Reply-To: <4F6B5A90.6030808@fuel7.com>
On 22/03/2012 18:00, Kyle Manna wrote:
>
> My pin mux is configured in u-boot and is as follows:
>
> /* CCDC_FIELD: gpio_95, uP-TXD4 */ \
> MUX_VAL(CP(CCDC_FIELD), (IDIS | PTD | DIS | M2)) \
> /* CCDC_HD: gpio_96, uP-RTS4# */ \
> MUX_VAL(CP(CCDC_HD), (IDIS | PTD | DIS | M2)) \
> /* CCDC_VD: gpio_97, uP-CTS4# */ \
> MUX_VAL(CP(CCDC_VD), (IEN | PTD | EN | M2)) \
> /* CCDC_WEN: gpio_98, uP-RXD4 */ \
> MUX_VAL(CP(CCDC_WEN), (IEN | PTD | DIS | M2)) \
>
Well, we are using the same pins !
> I've just validated my AM3505 board does in fact toggle the TX line and
> writes valid data. The running kernel is based on a linux-omap-3.1 and
> was the source for that patch.
>
> Since it sounds like you have the same pinmux, perhaps something changed
> elsewhere in the kernel?
Maybe, but registers looks good - and tracing the serial driver I have
not seen anything wrong.
> Have you tried validating that your hardware
> can toggle the pin as a GPIO first to eliminate any possibility of shorts?
I will do it now.
Thanks,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
WARNING: multiple messages have this Message-ID (diff)
From: sbabic@denx.de (Stefano Babic)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3
Date: Thu, 22 Mar 2012 18:11:59 +0100 [thread overview]
Message-ID: <4F6B5D5F.90206@denx.de> (raw)
In-Reply-To: <4F6B5A90.6030808@fuel7.com>
On 22/03/2012 18:00, Kyle Manna wrote:
>
> My pin mux is configured in u-boot and is as follows:
>
> /* CCDC_FIELD: gpio_95, uP-TXD4 */ \
> MUX_VAL(CP(CCDC_FIELD), (IDIS | PTD | DIS | M2)) \
> /* CCDC_HD: gpio_96, uP-RTS4# */ \
> MUX_VAL(CP(CCDC_HD), (IDIS | PTD | DIS | M2)) \
> /* CCDC_VD: gpio_97, uP-CTS4# */ \
> MUX_VAL(CP(CCDC_VD), (IEN | PTD | EN | M2)) \
> /* CCDC_WEN: gpio_98, uP-RXD4 */ \
> MUX_VAL(CP(CCDC_WEN), (IEN | PTD | DIS | M2)) \
>
Well, we are using the same pins !
> I've just validated my AM3505 board does in fact toggle the TX line and
> writes valid data. The running kernel is based on a linux-omap-3.1 and
> was the source for that patch.
>
> Since it sounds like you have the same pinmux, perhaps something changed
> elsewhere in the kernel?
Maybe, but registers looks good - and tracing the serial driver I have
not seen anything wrong.
> Have you tried validating that your hardware
> can toggle the pin as a GPIO first to eliminate any possibility of shorts?
I will do it now.
Thanks,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2012-03-22 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 18:47 [PATCH] ARM: OMAP: Add support for AM35xx UART4/ttyO3 Kyle Manna
2011-10-18 18:47 ` Kyle Manna
2011-10-18 18:47 ` Kyle Manna
2011-11-24 21:32 ` Paul Walmsley
2011-11-24 21:32 ` Paul Walmsley
2012-03-22 16:03 ` Stefano Babic
2012-03-22 16:03 ` Stefano Babic
2012-03-22 16:03 ` Stefano Babic
2012-03-22 17:00 ` Kyle Manna
2012-03-22 17:00 ` Kyle Manna
2012-03-22 17:00 ` Kyle Manna
2012-03-22 17:11 ` Stefano Babic [this message]
2012-03-22 17:11 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B5D5F.90206@denx.de \
--to=sbabic@denx.de \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=kyle.manna@fuel7.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.