* [patch] block: use caller's GFP flags instead of GFP_KERNEL
@ 2012-03-23 8:36 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-03-23 8:36 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, kernel-janitors
We should use the GFP flags that the caller specified instead of picking
our own. All the callers specify GFP_KERNEL so this doesn't make a
difference to how the kernel runs, it's just a cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/block/blk-core.c b/block/blk-core.c
index 3a78b00..414e822 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -483,7 +483,7 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id)
if (!q)
return NULL;
- q->id = ida_simple_get(&blk_queue_ida, 0, 0, GFP_KERNEL);
+ q->id = ida_simple_get(&blk_queue_ida, 0, 0, gfp_mask);
if (q->id < 0)
goto fail_q;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] block: use caller's GFP flags instead of GFP_KERNEL
@ 2012-03-23 8:36 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-03-23 8:36 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, kernel-janitors
We should use the GFP flags that the caller specified instead of picking
our own. All the callers specify GFP_KERNEL so this doesn't make a
difference to how the kernel runs, it's just a cleanup.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/block/blk-core.c b/block/blk-core.c
index 3a78b00..414e822 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -483,7 +483,7 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id)
if (!q)
return NULL;
- q->id = ida_simple_get(&blk_queue_ida, 0, 0, GFP_KERNEL);
+ q->id = ida_simple_get(&blk_queue_ida, 0, 0, gfp_mask);
if (q->id < 0)
goto fail_q;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] block: use caller's GFP flags instead of GFP_KERNEL
2012-03-23 8:36 ` Dan Carpenter
@ 2012-03-23 8:58 ` Jens Axboe
-1 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2012-03-23 8:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On 03/23/2012 09:36 AM, Dan Carpenter wrote:
> We should use the GFP flags that the caller specified instead of picking
> our own. All the callers specify GFP_KERNEL so this doesn't make a
> difference to how the kernel runs, it's just a cleanup.
Thanks Dan, applied to for-3.4/core
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] block: use caller's GFP flags instead of GFP_KERNEL
@ 2012-03-23 8:58 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2012-03-23 8:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On 03/23/2012 09:36 AM, Dan Carpenter wrote:
> We should use the GFP flags that the caller specified instead of picking
> our own. All the callers specify GFP_KERNEL so this doesn't make a
> difference to how the kernel runs, it's just a cleanup.
Thanks Dan, applied to for-3.4/core
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-23 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-23 8:36 [patch] block: use caller's GFP flags instead of GFP_KERNEL Dan Carpenter
2012-03-23 8:36 ` Dan Carpenter
2012-03-23 8:58 ` Jens Axboe
2012-03-23 8:58 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.