From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: santosh.shilimkar@ti.com, khilman@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linaro-dev@lists.linaro.org
Subject: Re: [RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically
Date: Fri, 23 Mar 2012 13:41:48 +0100 [thread overview]
Message-ID: <4F6C6F8C.8010307@linaro.org> (raw)
In-Reply-To: <CAORVsuUZUWrwzx0hYT4YC0HhwAzTKF+q++LPvg43iy-iYbTivA@mail.gmail.com>
On 03/23/2012 01:35 PM, Jean Pihet wrote:
> On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>> Use the new cpuidle API and define in the driver the states.
>>
>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>> ---
[ ... ]
>> /*
>> * Erratum i583: implementation for ES rev< Es1.2 on 3630. We cannot
> C7 is enabled only if the errata does not apply.
> This causes a problem with the statically defined C-states and also
> with the per C-state sysfs disable knob. A consistency check should be
> performed before trying to enter a state.
In the patch 5/9, I decrement the state_count if the errata applies. I
believe it is still compatible with the static C-states.
>> @@ -338,7 +372,6 @@ int __init omap3_idle_init(void)
>> drv->state_count = OMAP3_NUM_STATES;
>> cpuidle_register_driver(&omap3_idle_driver);
>>
>> - dev->state_count = OMAP3_NUM_STATES;
>> if (cpuidle_register_device(dev)) {
>> printk(KERN_ERR "%s: CPUidle register device failed\n",
>> __func__);
>> --
>> 1.7.5.4
>>
>
> Thanks!
> Jean
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically
Date: Fri, 23 Mar 2012 13:41:48 +0100 [thread overview]
Message-ID: <4F6C6F8C.8010307@linaro.org> (raw)
In-Reply-To: <CAORVsuUZUWrwzx0hYT4YC0HhwAzTKF+q++LPvg43iy-iYbTivA@mail.gmail.com>
On 03/23/2012 01:35 PM, Jean Pihet wrote:
> On Fri, Mar 23, 2012 at 10:26 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
>> Use the new cpuidle API and define in the driver the states.
>>
>> Signed-off-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>> ---
[ ... ]
>> /*
>> * Erratum i583: implementation for ES rev< Es1.2 on 3630. We cannot
> C7 is enabled only if the errata does not apply.
> This causes a problem with the statically defined C-states and also
> with the per C-state sysfs disable knob. A consistency check should be
> performed before trying to enter a state.
In the patch 5/9, I decrement the state_count if the errata applies. I
believe it is still compatible with the static C-states.
>> @@ -338,7 +372,6 @@ int __init omap3_idle_init(void)
>> drv->state_count = OMAP3_NUM_STATES;
>> cpuidle_register_driver(&omap3_idle_driver);
>>
>> - dev->state_count = OMAP3_NUM_STATES;
>> if (cpuidle_register_device(dev)) {
>> printk(KERN_ERR "%s: CPUidle register device failed\n",
>> __func__);
>> --
>> 1.7.5.4
>>
>
> Thanks!
> Jean
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2012-03-23 12:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 9:26 [RFC][PATCH 1/9] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 2/9] ARM: OMAP3: cpuidle - remove next_valid_state function Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
[not found] ` <1332494794-7810-2-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-03-23 12:21 ` Jean Pihet
2012-03-23 12:21 ` Jean Pihet
2012-03-23 9:26 ` [RFC][PATCH 3/9] ARM: OMAP3: cpuidle - set enable_off_mode as static Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 12:22 ` Jean Pihet
2012-03-23 12:22 ` Jean Pihet
2012-03-23 12:38 ` Daniel Lezcano
2012-03-23 12:38 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 4/9] ARM: OMAP3: define cpuidle statically Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 12:35 ` Jean Pihet
2012-03-23 12:35 ` Jean Pihet
2012-03-23 12:41 ` Daniel Lezcano [this message]
2012-03-23 12:41 ` Daniel Lezcano
2012-03-23 13:17 ` Jean Pihet
2012-03-23 13:17 ` Jean Pihet
2012-03-23 9:26 ` [RFC][PATCH 5/9] ARM: OMAP3: cpuidle - remove the 'valid' field Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 6/9] ARM: OMAP3: cpuidle - remove cpuidle_params_table Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 7/9] ARM: OMAP3: define statically the omap3_idle_data Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 8/9] ARM: OMAP3: cpuidle - use omap3_idle_data directly Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
2012-03-23 9:26 ` [RFC][PATCH 9/9] ARM: OMAP3/4: consolidate cpuidle Makefile Daniel Lezcano
2012-03-23 9:26 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C6F8C.8010307@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@ti.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.