* [PATCH] e1000: Silence sparse warnings by correcting type
@ 2012-03-19 13:44 Andrei Emeltchenko
2012-03-19 22:41 ` Julian Calaby
0 siblings, 1 reply; 8+ messages in thread
From: Andrei Emeltchenko @ 2012-03-19 13:44 UTC (permalink / raw)
To: linux-wireless
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Silence sparse warnings shown below:
...
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
...
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 6419a88..1bf73cf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)tx_desc;
const char *type;
@@ -3421,7 +3421,7 @@ rx_ring_summary:
for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)rx_desc;
const char *type;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] e1000: Silence sparse warnings by correcting type
@ 2012-03-19 14:00 Andrei Emeltchenko
2012-03-19 18:09 ` David Miller
0 siblings, 1 reply; 8+ messages in thread
From: Andrei Emeltchenko @ 2012-03-19 14:00 UTC (permalink / raw)
To: linux-kernel
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Silence sparse warnings shown below:
...
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
...
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 6419a88..1bf73cf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)tx_desc;
const char *type;
@@ -3421,7 +3421,7 @@ rx_ring_summary:
for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)rx_desc;
const char *type;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] e1000: Silence sparse warnings by correcting type
2012-03-19 14:00 Andrei Emeltchenko
@ 2012-03-19 18:09 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2012-03-19 18:09 UTC (permalink / raw)
To: Andrei.Emeltchenko.news; +Cc: linux-kernel
Networking patches posted only to linux-kernel are very likely to get
missed and dropped on the floor, please post them instead to
netdev@vger.kernel.org which is where the networking developers are
subscribed.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] e1000: Silence sparse warnings by correcting type
2012-03-19 13:44 Andrei Emeltchenko
@ 2012-03-19 22:41 ` Julian Calaby
2012-03-20 8:47 ` Andrei Emeltchenko
0 siblings, 1 reply; 8+ messages in thread
From: Julian Calaby @ 2012-03-19 22:41 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: linux-wireless
Hi Andrei,
Stupid question: Why have you sent this to linux-wireless?
Thanks,
Julian Calaby
On Tue, Mar 20, 2012 at 00:44, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
--
Julian Calaby
Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] e1000: Silence sparse warnings by correcting type
2012-03-19 22:41 ` Julian Calaby
@ 2012-03-20 8:47 ` Andrei Emeltchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andrei Emeltchenko @ 2012-03-20 8:47 UTC (permalink / raw)
To: Julian Calaby; +Cc: linux-wireless
Hi Julian,
On Tue, Mar 20, 2012 at 12:41 AM, Julian Calaby <julian.calaby@gmail.com> wrote:
> Hi Andrei,
>
> Stupid question: Why have you sent this to linux-wireless?
Sorry, my mistake :(
Regards,
Andrei
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] e1000: Silence sparse warnings by correcting type
@ 2012-03-20 8:59 Andrei Emeltchenko
2012-03-23 14:01 ` Andrei Emeltchenko
2012-03-25 9:45 ` Jeff Kirsher
0 siblings, 2 replies; 8+ messages in thread
From: Andrei Emeltchenko @ 2012-03-20 8:59 UTC (permalink / raw)
To: netdev
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Silence sparse warnings shown below:
...
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
cast to restricted __le64
...
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 6419a88..1bf73cf 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_main.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
@@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)tx_desc;
const char *type;
@@ -3421,7 +3421,7 @@ rx_ring_summary:
for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
- struct my_u { u64 a; u64 b; };
+ struct my_u { __le64 a; __le64 b; };
struct my_u *u = (struct my_u *)rx_desc;
const char *type;
--
1.7.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] e1000: Silence sparse warnings by correcting type
2012-03-20 8:59 [PATCH] e1000: Silence sparse warnings by correcting type Andrei Emeltchenko
@ 2012-03-23 14:01 ` Andrei Emeltchenko
2012-03-25 9:45 ` Jeff Kirsher
1 sibling, 0 replies; 8+ messages in thread
From: Andrei Emeltchenko @ 2012-03-23 14:01 UTC (permalink / raw)
To: netdev
ping
On Tue, Mar 20, 2012 at 10:59 AM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@gmail.com> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 6419a88..1bf73cf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
> for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
> struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
> struct e1000_buffer *buffer_info = &tx_ring->buffer_info[i];
> - struct my_u { u64 a; u64 b; };
> + struct my_u { __le64 a; __le64 b; };
> struct my_u *u = (struct my_u *)tx_desc;
> const char *type;
>
> @@ -3421,7 +3421,7 @@ rx_ring_summary:
> for (i = 0; rx_ring->desc && (i < rx_ring->count); i++) {
> struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
> struct e1000_buffer *buffer_info = &rx_ring->buffer_info[i];
> - struct my_u { u64 a; u64 b; };
> + struct my_u { __le64 a; __le64 b; };
> struct my_u *u = (struct my_u *)rx_desc;
> const char *type;
>
> --
> 1.7.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] e1000: Silence sparse warnings by correcting type
2012-03-20 8:59 [PATCH] e1000: Silence sparse warnings by correcting type Andrei Emeltchenko
2012-03-23 14:01 ` Andrei Emeltchenko
@ 2012-03-25 9:45 ` Jeff Kirsher
1 sibling, 0 replies; 8+ messages in thread
From: Jeff Kirsher @ 2012-03-25 9:45 UTC (permalink / raw)
To: Andrei Emeltchenko; +Cc: netdev
On 03/20/2012 01:59 AM, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
>
> Silence sparse warnings shown below:
> ...
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> drivers/net/ethernet/intel/e1000/e1000_main.c:3435:17: warning:
> cast to restricted __le64
> ...
>
> Signed-off-by: Andrei Emeltchenko<andrei.emeltchenko@intel.com>
> ---
> drivers/net/ethernet/intel/e1000/e1000_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c b/drivers/net/ethernet/intel/e1000/e1000_main.c
> index 6419a88..1bf73cf 100644
> --- a/drivers/net/ethernet/intel/e1000/e1000_main.c
> +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c
> @@ -3377,7 +3377,7 @@ static void e1000_dump(struct e1000_adapter *adapter)
> for (i = 0; tx_ring->desc&& (i< tx_ring->count); i++) {
> struct e1000_tx_desc *tx_desc = E1000_TX_DESC(*tx_ring, i);
> struct e1000_buffer *buffer_info =&tx_ring->buffer_info[i];
> - struct my_u { u64 a; u64 b; };
> + struct my_u { __le64 a; __le64 b; };
> struct my_u *u = (struct my_u *)tx_desc;
> const char *type;
>
> @@ -3421,7 +3421,7 @@ rx_ring_summary:
> for (i = 0; rx_ring->desc&& (i< rx_ring->count); i++) {
> struct e1000_rx_desc *rx_desc = E1000_RX_DESC(*rx_ring, i);
> struct e1000_buffer *buffer_info =&rx_ring->buffer_info[i];
> - struct my_u { u64 a; u64 b; };
> + struct my_u { __le64 a; __le64 b; };
> struct my_u *u = (struct my_u *)rx_desc;
> const char *type;
>
Helps if you CC the maintainers (i.e. me)
Thanks, I will add it to my queue of e1000 patches.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-03-25 9:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-20 8:59 [PATCH] e1000: Silence sparse warnings by correcting type Andrei Emeltchenko
2012-03-23 14:01 ` Andrei Emeltchenko
2012-03-25 9:45 ` Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2012-03-19 14:00 Andrei Emeltchenko
2012-03-19 18:09 ` David Miller
2012-03-19 13:44 Andrei Emeltchenko
2012-03-19 22:41 ` Julian Calaby
2012-03-20 8:47 ` Andrei Emeltchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.