From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Randy Dunlap <rdunlap@xenotime.net>
Cc: Paul Gortmaker <paul.gortmaker@gmail.com>,
<klassert@mathematik.tu-chemnitz.de>, <netdev@vger.kernel.org>,
<linux-mips@linux-mips.org>
Subject: Re: [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x
Date: Mon, 26 Mar 2012 11:38:32 -0400 [thread overview]
Message-ID: <4F708D78.2040102@windriver.com> (raw)
In-Reply-To: <4F70834E.3000308@mvista.com>
On 12-03-26 10:55 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 03/26/2012 05:38 PM, Paul Gortmaker wrote:
>
>>> I hate to add in more #ifdef CONFIG_PCI but there are already
>>> quite a few in this driver, and it seems like it hasn't been
>>> built with CONFIG_PCI set to off in quite some time.
>
>> Actually, please scrap this patch. The uglyness of more ifdefs
>> made me look at it again. It should be do-able in a cleaner way
>> with stubs, and it appears this may even be similar to an old fail
>> from the past:
>
>> http://lkml.indiana.edu/hypermail/linux/kernel/1107.3/00109.html
>
> Also, see this patch:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0da0ead90122578ef6e4afba9ba4bcd3455fd8e8
>
> The driver patch this was done for is still in the -mm tree after all these
> years.:-)
>
>> I'll dig into it some more and follow up.
>
> I thought I addressed all issues with compilation of this driver with
> CONFIG_PCI=n. Apparently not, and some seem to have accumulated over time...
I got sidetracked working on other things, but I did manage to
learn this so far - It turns out that Randy fixed it and then
James un-fixed it in this commit:
commit 97a29d59fc222b36bac3ee3a8ae994f65bf7ffdf
Author: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Mon Jan 30 10:40:47 2012 -0600
[PARISC] fix compile break caused by iomap: make IOPORT/PCI mapping functions conditional
Reverting the above and mips builds 3c59x just fine. Note that MIPS
allmodconfig does not have either CONFIG_GENERIC_IOMAP or the other
CONFIG_GENERIC_PCI_IOMAP options.
Paul.
--
>
>> Thanks,
>> Paul.
>
> WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Randy Dunlap <rdunlap@xenotime.net>
Cc: Paul Gortmaker <paul.gortmaker@gmail.com>,
klassert@mathematik.tu-chemnitz.de, netdev@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x
Date: Mon, 26 Mar 2012 11:38:32 -0400 [thread overview]
Message-ID: <4F708D78.2040102@windriver.com> (raw)
Message-ID: <20120326153832.fRse3k-P0FZhWU2ZGxjhCZFennTH3JqvOzqfVQHB99M@z> (raw)
In-Reply-To: <4F70834E.3000308@mvista.com>
On 12-03-26 10:55 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 03/26/2012 05:38 PM, Paul Gortmaker wrote:
>
>>> I hate to add in more #ifdef CONFIG_PCI but there are already
>>> quite a few in this driver, and it seems like it hasn't been
>>> built with CONFIG_PCI set to off in quite some time.
>
>> Actually, please scrap this patch. The uglyness of more ifdefs
>> made me look at it again. It should be do-able in a cleaner way
>> with stubs, and it appears this may even be similar to an old fail
>> from the past:
>
>> http://lkml.indiana.edu/hypermail/linux/kernel/1107.3/00109.html
>
> Also, see this patch:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0da0ead90122578ef6e4afba9ba4bcd3455fd8e8
>
> The driver patch this was done for is still in the -mm tree after all these
> years.:-)
>
>> I'll dig into it some more and follow up.
>
> I thought I addressed all issues with compilation of this driver with
> CONFIG_PCI=n. Apparently not, and some seem to have accumulated over time...
I got sidetracked working on other things, but I did manage to
learn this so far - It turns out that Randy fixed it and then
James un-fixed it in this commit:
commit 97a29d59fc222b36bac3ee3a8ae994f65bf7ffdf
Author: James Bottomley <James.Bottomley@HansenPartnership.com>
Date: Mon Jan 30 10:40:47 2012 -0600
[PARISC] fix compile break caused by iomap: make IOPORT/PCI mapping functions conditional
Reverting the above and mips builds 3c59x just fine. Note that MIPS
allmodconfig does not have either CONFIG_GENERIC_IOMAP or the other
CONFIG_GENERIC_PCI_IOMAP options.
Paul.
--
>
>> Thanks,
>> Paul.
>
> WBR, Sergei
next prev parent reply other threads:[~2012-03-26 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 1:11 [PATCH] netdev: fix compile issues for !CONFIG_PCI in 3c59x Paul Gortmaker
2012-03-26 13:38 ` Paul Gortmaker
2012-03-26 14:55 ` Sergei Shtylyov
2012-03-26 15:38 ` Paul Gortmaker [this message]
2012-03-26 15:38 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F708D78.2040102@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@gmail.com \
--cc=rdunlap@xenotime.net \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.