[PATCH 43/73] libselinux: avc_netlink_recieve handle EINTR FIXME

[PATCH 43/73] libselinux: avc_netlink_recieve handle EINTR FIXME

[Daniel J Walsh]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


   This patch looks good to me. acked.

I think we should do this rather then have applications like dbus
randomly crash, and people not notice it for years.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9x4d0ACgkQrlYvE4MpobMo3QCgqaLM8fRuIgAu/4T6VgsZEppA
ipcAoKLspjezOWW4H2NT8mjcm2UbOuCg
=pAU/
-----END PGP SIGNATURE-----

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0043-libselinux-avc_netlink_recieve-handle-EINTR-FIXME.patch --]
[-- Type: text/x-patch; name="0043-libselinux-avc_netlink_recieve-handle-EINTR-FIXME.patch", Size: 0 bytes --]

Re: [PATCH 43/73] libselinux: avc_netlink_recieve handle EINTR FIXME

[Colin Walters]

On Tue, 2012-03-27 at 11:50 -0400, Daniel J Walsh wrote:
> This patch looks good to me. acked.
> 
> I think we should do this rather then have applications like dbus
> randomly crash, and people not notice it for years.

Handling of EINTR is a very interesting thing in operating systems.
For example, the Python interpreter relies on receiving EINTR
from system calls when you press Control-C at the toplevel.

However in this case the AVC thread is hidden from the consumer, so
it's clearly correct to retry on EINTR.



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.