From: "Mathieu Gagné" <mgagne@iweb.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: xl: Need help with overflow and error handling for vif rate support
Date: Tue, 27 Mar 2012 13:04:45 -0400 [thread overview]
Message-ID: <4F71F32D.9080601@iweb.com> (raw)
Hi,
I'm working a patch to add support for vif rate limiting support to
libxl/xl. [1]
I'm especially working on using uint64_t instead of uint32_t [2] and
adding error handling. [3]
- How should I check for overflows when multiplying 2 uint64_t together?
- I'm currently using math.h and log. Is it the correct approach?
- How should I handle errors?
- Should I do something similar to libxlu_disk.c?
- Should xlu_vif_parse_rate prints an error and returns an error code?
- If the error is from one of the "helpers", should they print an
error too or should xlu_vif_parse_rate deals with it?
Any help would be greatly appreciated.
Regards,
[1] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01596.html
[2] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01627.html
[3] http://lists.xen.org/archives/html/xen-devel/2012-03/msg01738.html
--
Mathieu
next reply other threads:[~2012-03-27 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 17:04 Mathieu Gagné [this message]
2012-03-28 9:57 ` xl: Need help with overflow and error handling for vif rate support Ian Campbell
2012-03-29 14:36 ` Ian Jackson
2012-03-29 15:02 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71F32D.9080601@iweb.com \
--to=mgagne@iweb.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.