From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Andreas Faerber <andreas.faerber@web.de>,
qemu-devel@nongnu.org, Emre Ersin <emre.ersin@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Fix conversion from lower to upper case with Turkish locale
Date: Tue, 27 Mar 2012 11:09:22 -0600 [thread overview]
Message-ID: <4F71F442.7080201@redhat.com> (raw)
In-Reply-To: <1332867470-29780-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On 03/27/2012 10:57 AM, Stefan Weil wrote:
> Some locale settings let make fail or create wrong results
> because tr '[:lower:]' '[:upper:]' which is used to convert
> from lower to upper case depends on the locale.
>
> With locale tr_TR.UTF-8, lower case 'i' is not converted to 'I'.
> This results in wrong entries in config-host.h like these ones:
>
> #define CONFIG_QEMU_PREFiX "/usr/local"
> #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
> for card in $audio_card_list; do
> - def=CONFIG_`echo $card | tr '[:lower:]' '[:upper:]'`
> + def=CONFIG_`echo $card | tr '[a-z]' '[A-Z]'`
NACK. POSIX says that 'tr a-z' is unspecified outside of the POSIX
locale, but without setting LC_ALL=C, you aren't guaranteeing the POSIX
locale. If you want to be portable without use of [:lower:], you have
to spell it out, with abcdefghijklmnopqrstuvwxyz.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Andreas Faerber <andreas.faerber@web.de>,
qemu-devel@nongnu.org, Emre Ersin <emre.ersin@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Fix conversion from lower to upper case with Turkish locale
Date: Tue, 27 Mar 2012 11:09:22 -0600 [thread overview]
Message-ID: <4F71F442.7080201@redhat.com> (raw)
In-Reply-To: <1332867470-29780-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On 03/27/2012 10:57 AM, Stefan Weil wrote:
> Some locale settings let make fail or create wrong results
> because tr '[:lower:]' '[:upper:]' which is used to convert
> from lower to upper case depends on the locale.
>
> With locale tr_TR.UTF-8, lower case 'i' is not converted to 'I'.
> This results in wrong entries in config-host.h like these ones:
>
> #define CONFIG_QEMU_PREFiX "/usr/local"
> #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
> for card in $audio_card_list; do
> - def=CONFIG_`echo $card | tr '[:lower:]' '[:upper:]'`
> + def=CONFIG_`echo $card | tr '[a-z]' '[A-Z]'`
NACK. POSIX says that 'tr a-z' is unspecified outside of the POSIX
locale, but without setting LC_ALL=C, you aren't guaranteeing the POSIX
locale. If you want to be portable without use of [:lower:], you have
to spell it out, with abcdefghijklmnopqrstuvwxyz.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-03-27 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 16:57 [Qemu-trivial] [PATCH] Fix conversion from lower to upper case with Turkish locale Stefan Weil
2012-03-27 16:57 ` [Qemu-devel] " Stefan Weil
2012-03-27 17:09 ` Eric Blake [this message]
2012-03-27 17:09 ` Eric Blake
2012-03-27 17:28 ` [Qemu-trivial] " Stefan Weil
2012-03-27 17:28 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F71F442.7080201@redhat.com \
--to=eblake@redhat.com \
--cc=andreas.faerber@web.de \
--cc=emre.ersin@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.