From: Jon Hunter <jon-hunter@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Rajendra Nayak <rnayak@ti.com>,
b-cousson@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP: hwmod: Fix error handling in functions used OMAP4 onwards
Date: Wed, 28 Mar 2012 11:36:27 -0500 [thread overview]
Message-ID: <4F733E0B.2020901@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203272039010.22961@utopia.booyaka.com>
Hi Paul,
On 3/27/2012 21:39, Paul Walmsley wrote:
> Hi Jon,
>
> On Tue, 27 Mar 2012, Jon Hunter wrote:
>
>> On 3/27/2012 4:58, Rajendra Nayak wrote:
>>
>>> diff --git a/arch/arm/mach-omap2/omap_hwmod.c
>>> b/arch/arm/mach-omap2/omap_hwmod.c
>>> index 8ac26f2..f2a9afa 100644
>>> --- a/arch/arm/mach-omap2/omap_hwmod.c
>>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
>>> @@ -808,7 +808,7 @@ static void _enable_module(struct omap_hwmod *oh)
>>> */
>>> static int _omap4_wait_target_disable(struct omap_hwmod *oh)
>>> {
>>> - if (!cpu_is_omap44xx())
>>> + if (cpu_is_omap24xx() || cpu_is_omap34xx())
>>> return 0;
>>
>> What about omap36xx?
>
> Unfortunately, cpu_is_omap34xx() also covers OMAP36xx :-(
Thanks. Is that still the case when MULTI_OMAP2 is defined? I can see if
it is not define then it will always return 1 for all OMAP3, but for
MULTI_OMAP2 it did not seem to me that it would. May be I should test ...
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: hwmod: Fix error handling in functions used OMAP4 onwards
Date: Wed, 28 Mar 2012 11:36:27 -0500 [thread overview]
Message-ID: <4F733E0B.2020901@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203272039010.22961@utopia.booyaka.com>
Hi Paul,
On 3/27/2012 21:39, Paul Walmsley wrote:
> Hi Jon,
>
> On Tue, 27 Mar 2012, Jon Hunter wrote:
>
>> On 3/27/2012 4:58, Rajendra Nayak wrote:
>>
>>> diff --git a/arch/arm/mach-omap2/omap_hwmod.c
>>> b/arch/arm/mach-omap2/omap_hwmod.c
>>> index 8ac26f2..f2a9afa 100644
>>> --- a/arch/arm/mach-omap2/omap_hwmod.c
>>> +++ b/arch/arm/mach-omap2/omap_hwmod.c
>>> @@ -808,7 +808,7 @@ static void _enable_module(struct omap_hwmod *oh)
>>> */
>>> static int _omap4_wait_target_disable(struct omap_hwmod *oh)
>>> {
>>> - if (!cpu_is_omap44xx())
>>> + if (cpu_is_omap24xx() || cpu_is_omap34xx())
>>> return 0;
>>
>> What about omap36xx?
>
> Unfortunately, cpu_is_omap34xx() also covers OMAP36xx :-(
Thanks. Is that still the case when MULTI_OMAP2 is defined? I can see if
it is not define then it will always return 1 for all OMAP3, but for
MULTI_OMAP2 it did not seem to me that it would. May be I should test ...
Cheers
Jon
next prev parent reply other threads:[~2012-03-28 16:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 9:58 [PATCH] ARM: OMAP: hwmod: Fix error handling in functions used OMAP4 onwards Rajendra Nayak
2012-03-27 9:58 ` Rajendra Nayak
2012-03-27 19:52 ` Jon Hunter
2012-03-27 19:52 ` Jon Hunter
2012-03-28 2:39 ` Paul Walmsley
2012-03-28 2:39 ` Paul Walmsley
2012-03-28 16:36 ` Jon Hunter [this message]
2012-03-28 16:36 ` Jon Hunter
2012-03-28 6:32 ` Hiremath, Vaibhav
2012-03-28 6:32 ` Hiremath, Vaibhav
2012-03-29 6:12 ` Rajendra Nayak
2012-03-29 6:12 ` Rajendra Nayak
2012-03-29 8:56 ` Hiremath, Vaibhav
2012-03-29 8:56 ` Hiremath, Vaibhav
2012-03-29 9:02 ` Rajendra Nayak
2012-03-29 9:02 ` Rajendra Nayak
2012-03-29 9:14 ` Hiremath, Vaibhav
2012-03-29 9:14 ` Hiremath, Vaibhav
2012-03-29 15:01 ` Jon Hunter
2012-03-29 15:01 ` Jon Hunter
2012-03-29 15:03 ` Jon Hunter
2012-03-29 15:03 ` Jon Hunter
2012-03-30 7:14 ` Hiremath, Vaibhav
2012-03-30 7:14 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F733E0B.2020901@ti.com \
--to=jon-hunter@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.