From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Chao Xie <chao.xie@marvell.com>
Cc: linux-input@vger.kernel.org, eric.y.miao@gmail.com,
haojian.zhuang@marvell.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask
Date: Wed, 28 Mar 2012 22:04:05 +0400 [thread overview]
Message-ID: <4F735295.2010604@mvista.com> (raw)
In-Reply-To: <1332911324-9840-4-git-send-email-chao.xie@marvell.com>
Hello.
On 03/28/2012 09:08 AM, Chao Xie wrote:
> Direct keys usage may not start from KP_DKIN0, add a msk option
> to configure the specifics for platforms that can skip some keys.
> Signed-off-by: Chao Xie<chao.xie@marvell.com>
[...]
> diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
> index b41ebda..661892b 100644
> --- a/drivers/input/keyboard/pxa27x_keypad.c
> +++ b/drivers/input/keyboard/pxa27x_keypad.c
> @@ -391,7 +391,12 @@ static void pxa27x_keypad_config(struct pxa27x_keypad *keypad)
> if (pdata->direct_key_num> direct_key_num)
> direct_key_num = pdata->direct_key_num;
>
> - keypad->direct_key_mask = ((1<< direct_key_num) - 1)& ~mask;
> + /* Direct keys usage may not start from KP_DKIN0, check the platfrom
> + * msk data to config the specific */
The preferred multi-line comment style is not this one. You got it right in
the previous patch. :-)
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask
Date: Wed, 28 Mar 2012 22:04:05 +0400 [thread overview]
Message-ID: <4F735295.2010604@mvista.com> (raw)
In-Reply-To: <1332911324-9840-4-git-send-email-chao.xie@marvell.com>
Hello.
On 03/28/2012 09:08 AM, Chao Xie wrote:
> Direct keys usage may not start from KP_DKIN0, add a msk option
> to configure the specifics for platforms that can skip some keys.
> Signed-off-by: Chao Xie<chao.xie@marvell.com>
[...]
> diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
> index b41ebda..661892b 100644
> --- a/drivers/input/keyboard/pxa27x_keypad.c
> +++ b/drivers/input/keyboard/pxa27x_keypad.c
> @@ -391,7 +391,12 @@ static void pxa27x_keypad_config(struct pxa27x_keypad *keypad)
> if (pdata->direct_key_num> direct_key_num)
> direct_key_num = pdata->direct_key_num;
>
> - keypad->direct_key_mask = ((1<< direct_key_num) - 1)& ~mask;
> + /* Direct keys usage may not start from KP_DKIN0, check the platfrom
> + * msk data to config the specific */
The preferred multi-line comment style is not this one. You got it right in
the previous patch. :-)
WBR, Sergei
next prev parent reply other threads:[~2012-03-28 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 5:08 [PATCH 1/4] Input: pxa27x_keypad keep clock on as wakeup source Chao Xie
2012-03-28 5:08 ` Chao Xie
2012-03-28 5:08 ` [PATCH 2/4] Input: pxa27x_keypad bug fix for direct_key_mask Chao Xie
2012-03-28 5:08 ` Chao Xie
2012-03-28 5:08 ` [PATCH 3/4] Input: pxa27x_keypad direct key may be low active Chao Xie
2012-03-28 5:08 ` Chao Xie
2012-03-28 5:08 ` [PATCH 4/4] Input: pxa27x_keypad add choice to set direct_key_mask Chao Xie
2012-03-28 5:08 ` Chao Xie
2012-03-28 18:04 ` Sergei Shtylyov [this message]
2012-03-28 18:04 ` Sergei Shtylyov
2012-03-29 9:15 ` Chao Xie
2012-03-29 9:15 ` Chao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F735295.2010604@mvista.com \
--to=sshtylyov@mvista.com \
--cc=chao.xie@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.