* [PATCH] ia32-base.inc: Use '=' for IMAGE_FSTYPES
@ 2012-03-23 17:34 Tom Rini
2012-03-28 18:16 ` [meta-intel][PATCH v2] ia32-base.inc: Use '=+' " Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2012-03-23 17:34 UTC (permalink / raw)
To: yocto; +Cc: Darren Hart
As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/019772.html
a machine conf file should use '=' to set IMAGE_FSTYPES.
Cc: Kishore Bodke <kishore.k.bodke@intel.com>
Cc: Tom Zanussi <tom.zanussi@intel.com>
Cc: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
conf/machine/include/ia32-base.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/conf/machine/include/ia32-base.inc b/conf/machine/include/ia32-base.inc
index 9b2ef5a..74ab5a5 100644
--- a/conf/machine/include/ia32-base.inc
+++ b/conf/machine/include/ia32-base.inc
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES = "ext3 cpio.gz live"
KERNEL_IMAGETYPE ?= "bzImage"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES
2012-03-23 17:34 [PATCH] ia32-base.inc: Use '=' for IMAGE_FSTYPES Tom Rini
@ 2012-03-28 18:16 ` Tom Rini
2012-03-28 21:42 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2012-03-28 18:16 UTC (permalink / raw)
To: yocto; +Cc: Darren Hart
As per
http://lists.linuxtogo.org/pipermail/openembedded-core/2012-March/020053.html
a machine conf file should use '=+' to set IMAGE_FSTYPES.
Cc: Kishore Bodke <kishore.k.bodke@intel.com>
Cc: Tom Zanussi <tom.zanussi@intel.com>
Cc: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Tom Rini <trini@ti.com>
---
conf/machine/include/ia32-base.inc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/conf/machine/include/ia32-base.inc b/conf/machine/include/ia32-base.inc
index 9b2ef5a..817ee2d 100644
--- a/conf/machine/include/ia32-base.inc
+++ b/conf/machine/include/ia32-base.inc
@@ -11,7 +11,7 @@ MACHINE_FEATURES += "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \
MACHINE_EXTRA_RRECOMMENDS += "kernel-modules eee-acpi-scripts"
MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "grub"
-IMAGE_FSTYPES += "ext3 cpio.gz live"
+IMAGE_FSTYPES =+ "ext3 cpio.gz live"
KERNEL_IMAGETYPE ?= "bzImage"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES
2012-03-28 18:16 ` [meta-intel][PATCH v2] ia32-base.inc: Use '=+' " Tom Rini
@ 2012-03-28 21:42 ` Khem Raj
2012-03-28 22:06 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2012-03-28 21:42 UTC (permalink / raw)
To: Tom Rini; +Cc: yocto, Darren Hart
On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
>
> -IMAGE_FSTYPES += "ext3 cpio.gz live"
> +IMAGE_FSTYPES =+ "ext3 cpio.gz live"
whats the difference ?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES
2012-03-28 21:42 ` Khem Raj
@ 2012-03-28 22:06 ` Tom Rini
2012-03-28 23:53 ` Darren Hart
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2012-03-28 22:06 UTC (permalink / raw)
To: Khem Raj; +Cc: yocto, Darren Hart
On Wed, Mar 28, 2012 at 02:42:36PM -0700, Khem Raj wrote:
> On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
> >
> > -IMAGE_FSTYPES += "ext3 cpio.gz live"
> > +IMAGE_FSTYPES =+ "ext3 cpio.gz live"
>
> whats the difference ?
Consistency. Or blame Richard for saying "no, wait, =+" :)
--
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-intel][PATCH v2] ia32-base.inc: Use '=+' for IMAGE_FSTYPES
2012-03-28 22:06 ` Tom Rini
@ 2012-03-28 23:53 ` Darren Hart
2012-03-29 0:50 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Darren Hart @ 2012-03-28 23:53 UTC (permalink / raw)
To: Tom Rini; +Cc: yocto
On 03/28/2012 03:06 PM, Tom Rini wrote:
> On Wed, Mar 28, 2012 at 02:42:36PM -0700, Khem Raj wrote:
>> On Wed, Mar 28, 2012 at 11:16 AM, Tom Rini <trini@ti.com> wrote:
>>>
>>> -IMAGE_FSTYPES += "ext3 cpio.gz live"
>>> +IMAGE_FSTYPES =+ "ext3 cpio.gz live"
>>
>> whats the difference ?
>
> Consistency. Or blame Richard for saying "no, wait, =+" :)
>
+= append
=+ prepend
Doesn't seem to me that it would impact the final output at all.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-03-29 2:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-23 17:34 [PATCH] ia32-base.inc: Use '=' for IMAGE_FSTYPES Tom Rini
2012-03-28 18:16 ` [meta-intel][PATCH v2] ia32-base.inc: Use '=+' " Tom Rini
2012-03-28 21:42 ` Khem Raj
2012-03-28 22:06 ` Tom Rini
2012-03-28 23:53 ` Darren Hart
2012-03-29 0:50 ` Khem Raj
2012-03-29 2:21 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.