From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] blkcg: change a spin_lock() to spin_lock_irq()
Date: Thu, 29 Mar 2012 18:57:31 +0000 [thread overview]
Message-ID: <4F74B09B.3070100@kernel.dk> (raw)
In-Reply-To: <20120329185119.GA21812@elgon.mountain>
On 2012-03-29 20:51, Dan Carpenter wrote:
> Smatch complains that we re-enable IRQs twice. It looks like we forgot
> to disable them here on the spin_trylock() failure path. This was added
> in 9f13ef678e "blkcg: use double locking instead of RCU for blkg
> synchronization".
Thanks, that is indeed a screwup. Fix applied.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] blkcg: change a spin_lock() to spin_lock_irq()
Date: Thu, 29 Mar 2012 20:57:31 +0200 [thread overview]
Message-ID: <4F74B09B.3070100@kernel.dk> (raw)
In-Reply-To: <20120329185119.GA21812@elgon.mountain>
On 2012-03-29 20:51, Dan Carpenter wrote:
> Smatch complains that we re-enable IRQs twice. It looks like we forgot
> to disable them here on the spin_trylock() failure path. This was added
> in 9f13ef678e "blkcg: use double locking instead of RCU for blkg
> synchronization".
Thanks, that is indeed a screwup. Fix applied.
--
Jens Axboe
next prev parent reply other threads:[~2012-03-29 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 18:51 [patch] blkcg: change a spin_lock() to spin_lock_irq() Dan Carpenter
2012-03-29 18:51 ` Dan Carpenter
2012-03-29 18:57 ` Jens Axboe [this message]
2012-03-29 18:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F74B09B.3070100@kernel.dk \
--to=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.