From: Timur Tabi <timur@freescale.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: fsl: enable ssi clock in probe function
Date: Fri, 30 Mar 2012 08:03:28 -0500 [thread overview]
Message-ID: <4F75AF20.6080009@freescale.com> (raw)
In-Reply-To: <20120330055543.GH19506@S2101-09.ap.freescale.net>
Shawn Guo wrote:
> I guess you only meant mpc85xx_defconfig (and mpc85xx_smp_defconfig).
> I sent the patch after compile-testing for mpc85xx_defconfig, and
> took it for granted that mpc8610_hpcd_defconfig will also compile.
> But I just discovered that PPC_CLOCK is not enabled for
> mpc8610_hpcd_defconfig, so it fails on the final link.
Argh. I was thinking about testing mpc8610 as well, but I thought, "Hey,
p1022ds works, why bother testing the 8610? Why would it fail?"
> I just sent a patch proposing to fix it by always building in PPC_CLOCK
> for FSL_SOC.
You'll need to get Kumar Gala's ACK on that one, but if only the 8610 is
broken, then I don't think he'll like it.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: timur@freescale.com (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: enable ssi clock in probe function
Date: Fri, 30 Mar 2012 08:03:28 -0500 [thread overview]
Message-ID: <4F75AF20.6080009@freescale.com> (raw)
In-Reply-To: <20120330055543.GH19506@S2101-09.ap.freescale.net>
Shawn Guo wrote:
> I guess you only meant mpc85xx_defconfig (and mpc85xx_smp_defconfig).
> I sent the patch after compile-testing for mpc85xx_defconfig, and
> took it for granted that mpc8610_hpcd_defconfig will also compile.
> But I just discovered that PPC_CLOCK is not enabled for
> mpc8610_hpcd_defconfig, so it fails on the final link.
Argh. I was thinking about testing mpc8610 as well, but I thought, "Hey,
p1022ds works, why bother testing the 8610? Why would it fail?"
> I just sent a patch proposing to fix it by always building in PPC_CLOCK
> for FSL_SOC.
You'll need to get Kumar Gala's ACK on that one, but if only the 8610 is
broken, then I don't think he'll like it.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-03-30 13:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 2:53 [PATCH] ASoC: fsl: enable ssi clock in probe function Shawn Guo
2012-03-29 2:53 ` Shawn Guo
2012-03-29 11:29 ` Mark Brown
2012-03-29 11:29 ` Mark Brown
2012-03-29 16:01 ` Timur Tabi
2012-03-29 16:01 ` Timur Tabi
2012-03-29 16:09 ` Shawn Guo
2012-03-29 16:09 ` Shawn Guo
2012-03-29 16:23 ` Timur Tabi
2012-03-29 16:23 ` Timur Tabi
2012-03-29 16:30 ` Mark Brown
2012-03-29 16:30 ` Mark Brown
2012-03-30 5:55 ` Shawn Guo
2012-03-30 5:55 ` Shawn Guo
2012-03-30 13:03 ` Timur Tabi [this message]
2012-03-30 13:03 ` Timur Tabi
2012-03-30 13:16 ` Shawn Guo
2012-03-30 13:16 ` Shawn Guo
2012-03-30 13:19 ` Timur Tabi
2012-03-30 13:19 ` Timur Tabi
2012-03-29 16:30 ` Mark Brown
2012-03-29 16:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F75AF20.6080009@freescale.com \
--to=timur@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.