[PATCH 1/8] Documentation: remove 'mach' from dontdiff file

[PATCH 1/8] Documentation: remove 'mach' from dontdiff file

[Randy Dunlap]

From: H Hartley Sweeten <hartleys@visionengravers.com>

Documentation: remove mach from dontdiff file

The mach entry in the dontdiff file causes all the arch/arm/mach-*/include/mach
directories to be skipped.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
 Documentation/dontdiff |    1 -
 1 file changed, 1 deletion(-)

--- lnx-33.orig/Documentation/dontdiff
+++ lnx-33/Documentation/dontdiff
@@ -158,7 +158,6 @@ logo_*.c
 logo_*_clut224.c
 logo_*_mono.c
 lxdialog
-mach
 mach-types
 mach-types.h
 machtypes.h

Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

[Linus Torvalds]

On Fri, Mar 30, 2012 at 1:36 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: H Hartley Sweeten <hartleys@visionengravers.com>
>
> Documentation: remove mach from dontdiff file

Grr.

Most of these patches have the same stupid problem: why the *hell* do
you repeat the single-line top-level description in both the Subject
line and the body of the email? It only results in stupid duplicate
lines in the commit logs.

This is a disease. I don't know who the heck started doing it, but
it's WRONG. It's stupid. What broken piece-of-shit tool is it that
does this braindamage?

Fix it. Stop sending these broken commit messages to people.

I'm grumpy, yes, because this is a common problem. I see it all over
the place, and it makes our commit logs look f*cking retarded.

If you absolutely need to repeat the subject line in the body of the
email, do it together with the author line, and mark it as such, ie do
this:

  From: H Hartley Sweeten <hartleys@visionengravers.com>
  Subject: Documentation: remove mach from dontdiff file

so that git sees that it's a repeat of the subject line. Don't just
put it in the body as another stupid repeat.

                                  Linus

Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

[Randy Dunlap]

On 03/30/2012 03:39 PM, Linus Torvalds wrote:

> On Fri, Mar 30, 2012 at 1:36 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>> From: H Hartley Sweeten <hartleys@visionengravers.com>
>>
>> Documentation: remove mach from dontdiff file
> 
> Grr.
> 
> Most of these patches have the same stupid problem: why the *hell* do
> you repeat the single-line top-level description in both the Subject
> line and the body of the email? It only results in stupid duplicate
> lines in the commit logs.
> 
> This is a disease. I don't know who the heck started doing it, but
> it's WRONG. It's stupid. What broken piece-of-shit tool is it that
> does this braindamage?
> 
> Fix it. Stop sending these broken commit messages to people.
> 
> I'm grumpy, yes, because this is a common problem. I see it all over
> the place, and it makes our commit logs look f*cking retarded.
> 
> If you absolutely need to repeat the subject line in the body of the
> email, do it together with the author line, and mark it as such, ie do
> this:
> 
>   From: H Hartley Sweeten <hartleys@visionengravers.com>
>   Subject: Documentation: remove mach from dontdiff file
> 
> so that git sees that it's a repeat of the subject line. Don't just
> put it in the body as another stupid repeat.


I see.  Thanks for the info.

Shall I resend all of these?

-- 
~Randy

Re: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file

[Linus Torvalds]

On Fri, Mar 30, 2012 at 4:15 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> Shall I resend all of these?

No, I went through and fixed them up since I noticed. But sometimes I
don't notice, and I know for a fact that other submaintainers also
don't notice, so we've got tons of those duplicate lines in our tree.
Just fix your future patches.

The last one also didn't apply cleanly for some reason. I didn't
figure out what made it not apply, I tried several different versions
and then just decided to force the patch manually. I wonder what base
you had used..

              Linus