From: Kukjin Kim <kgene.kim@samsung.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: S3C24XX: fix missing common.h in mach-s3c24xx/
Date: Fri, 30 Mar 2012 15:58:39 -0700 [thread overview]
Message-ID: <4F763A9F.2010907@samsung.com> (raw)
In-Reply-To: <4F74556F.10704@mvista.com>
Sergei Shtylyov wrote:
> Hello.
>
> On 29-03-2012 4:14, Kukjin Kim wrote:
>
[...]
>> +#ifdef CONFIG_CPU_S3C2410
>> +void s3c2410_restart(char mode, const char *cmd);
>> +#endif
>> +
>> +#ifdef CONFIG_CPU_S3C244X
>> +void s3c244x_restart(char mode, const char *cmd);
>> +#endif
>
> Those #ifdef's around function prototypes are not necessary.
>
OK, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S3C24XX: fix missing common.h in mach-s3c24xx/
Date: Fri, 30 Mar 2012 15:58:39 -0700 [thread overview]
Message-ID: <4F763A9F.2010907@samsung.com> (raw)
In-Reply-To: <4F74556F.10704@mvista.com>
Sergei Shtylyov wrote:
> Hello.
>
> On 29-03-2012 4:14, Kukjin Kim wrote:
>
[...]
>> +#ifdef CONFIG_CPU_S3C2410
>> +void s3c2410_restart(char mode, const char *cmd);
>> +#endif
>> +
>> +#ifdef CONFIG_CPU_S3C244X
>> +void s3c244x_restart(char mode, const char *cmd);
>> +#endif
>
> Those #ifdef's around function prototypes are not necessary.
>
OK, thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-30 22:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 0:14 [PATCH] ARM: S3C24XX: fix missing common.h in mach-s3c24xx/ Kukjin Kim
2012-03-29 0:14 ` Kukjin Kim
2012-03-29 12:28 ` Sergei Shtylyov
2012-03-29 12:28 ` Sergei Shtylyov
2012-03-30 22:58 ` Kukjin Kim [this message]
2012-03-30 22:58 ` Kukjin Kim
2012-04-03 22:33 ` Paul Gortmaker
2012-04-03 22:33 ` Paul Gortmaker
2012-04-05 15:10 ` Kukjin Kim
2012-04-05 15:10 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F763A9F.2010907@samsung.com \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.