From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Chao Xie <chao.xie@marvell.com>
Cc: linux-input@vger.kernel.org, eric.y.miao@gmail.com,
haojian.zhuang@marvell.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/4] Input: pxa27x_keypad keep clock on as wakeup source
Date: Sun, 01 Apr 2012 01:47:10 +0400 [thread overview]
Message-ID: <4F777B5E.5080500@mvista.com> (raw)
In-Reply-To: <1333072698-15344-1-git-send-email-chao.xie@marvell.com>
Hello.
On 30-03-2012 5:58, Chao Xie wrote:
> When the keypad is used as wake up source, the clock can not
> be disabled. Or it can not detect key pressing.
> If the keypad is used as wake up source, when resume back,
> do not enable the clock and configure it again because the
> register content is retained.
> Signed-off-by: Chao Xie<chao.xie@marvell.com>
> ---
> drivers/input/keyboard/pxa27x_keypad.c | 27 ++++++++++++++++++---------
> 1 files changed, 18 insertions(+), 9 deletions(-)
> diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
> index 29fe1b2..1c5752f 100644
> --- a/drivers/input/keyboard/pxa27x_keypad.c
> +++ b/drivers/input/keyboard/pxa27x_keypad.c
[...]
> @@ -433,19 +437,24 @@ static int pxa27x_keypad_resume(struct device *dev)
> struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
> struct input_dev *input_dev = keypad->input_dev;
>
> + /*
> + * If the keypad is used as wake up source, the clock is not turned
> + * off. So do not need configure it again.
> + */
> if (device_may_wakeup(&pdev->dev))
> disable_irq_wake(keypad->irq);
> + else {
According to CodingStyle, {} should be an all branches of *if* statement,
if it's used at least in one branch.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/4] Input: pxa27x_keypad keep clock on as wakeup source
Date: Sun, 01 Apr 2012 01:47:10 +0400 [thread overview]
Message-ID: <4F777B5E.5080500@mvista.com> (raw)
In-Reply-To: <1333072698-15344-1-git-send-email-chao.xie@marvell.com>
Hello.
On 30-03-2012 5:58, Chao Xie wrote:
> When the keypad is used as wake up source, the clock can not
> be disabled. Or it can not detect key pressing.
> If the keypad is used as wake up source, when resume back,
> do not enable the clock and configure it again because the
> register content is retained.
> Signed-off-by: Chao Xie<chao.xie@marvell.com>
> ---
> drivers/input/keyboard/pxa27x_keypad.c | 27 ++++++++++++++++++---------
> 1 files changed, 18 insertions(+), 9 deletions(-)
> diff --git a/drivers/input/keyboard/pxa27x_keypad.c b/drivers/input/keyboard/pxa27x_keypad.c
> index 29fe1b2..1c5752f 100644
> --- a/drivers/input/keyboard/pxa27x_keypad.c
> +++ b/drivers/input/keyboard/pxa27x_keypad.c
[...]
> @@ -433,19 +437,24 @@ static int pxa27x_keypad_resume(struct device *dev)
> struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
> struct input_dev *input_dev = keypad->input_dev;
>
> + /*
> + * If the keypad is used as wake up source, the clock is not turned
> + * off. So do not need configure it again.
> + */
> if (device_may_wakeup(&pdev->dev))
> disable_irq_wake(keypad->irq);
> + else {
According to CodingStyle, {} should be an all branches of *if* statement,
if it's used at least in one branch.
WBR, Sergei
next prev parent reply other threads:[~2012-03-31 21:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 1:58 [PATCH V2 1/4] Input: pxa27x_keypad keep clock on as wakeup source Chao Xie
2012-03-30 1:58 ` Chao Xie
2012-03-30 1:53 ` Haojian Zhuang
2012-03-30 1:53 ` Haojian Zhuang
2012-03-30 1:58 ` [PATCH V2 2/4] Input: pxa27x_keypad bug fix for direct_key_mask Chao Xie
2012-03-30 1:58 ` Chao Xie
2012-03-30 1:58 ` [PATCH V2 3/4] Input: pxa27x_keypad direct key may be low active Chao Xie
2012-03-30 1:58 ` Chao Xie
2012-03-30 1:58 ` [PATCH V2 4/4] Input: pxa27x_keypad add choice to set direct_key_mask Chao Xie
2012-03-30 1:58 ` Chao Xie
2012-03-30 2:01 ` Haojian Zhuang
2012-03-30 2:01 ` Haojian Zhuang
2012-03-31 21:44 ` Sergei Shtylyov
2012-03-31 21:44 ` Sergei Shtylyov
2012-03-31 21:47 ` Sergei Shtylyov [this message]
2012-03-31 21:47 ` [PATCH V2 1/4] Input: pxa27x_keypad keep clock on as wakeup source Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F777B5E.5080500@mvista.com \
--to=sshtylyov@mvista.com \
--cc=chao.xie@marvell.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.